From 5e7e120fcb3db1ecdfa66c3845726d34636ca27d Mon Sep 17 00:00:00 2001 From: filipefurtad0 Date: Tue, 11 Jun 2024 13:32:26 -0600 Subject: [PATCH] Addresses Gaetans review Removes assertions from before block, as Delete case is tested elsewhere Declares enterprise_user variable as a non-instance variable --- spec/system/admin/products_v3/products_spec.rb | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/spec/system/admin/products_v3/products_spec.rb b/spec/system/admin/products_v3/products_spec.rb index 4a24515e1f..9b4aa04b4d 100644 --- a/spec/system/admin/products_v3/products_spec.rb +++ b/spec/system/admin/products_v3/products_spec.rb @@ -1365,9 +1365,6 @@ RSpec.describe 'As an enterprise user, I can manage my products', feature: :admi within modal_selector do page.find(delete_button_selector).click end - - expect(page).not_to have_selector(modal_selector) - expect(page).not_to have_selector(variant_selector) end it 'keeps the line item on the order (admin)' do @@ -1403,12 +1400,12 @@ RSpec.describe 'As an enterprise user, I can manage my products', feature: :admi end before do - @enterprise_user = create(:user) - @enterprise_user.enterprise_roles.build(enterprise: supplier_managed1).save - @enterprise_user.enterprise_roles.build(enterprise: supplier_managed2).save - @enterprise_user.enterprise_roles.build(enterprise: distributor_managed).save + enterprise_user = create(:user) + enterprise_user.enterprise_roles.build(enterprise: supplier_managed1).save + enterprise_user.enterprise_roles.build(enterprise: supplier_managed2).save + enterprise_user.enterprise_roles.build(enterprise: distributor_managed).save - login_as @enterprise_user + login_as enterprise_user end it "shows only products that I supply" do