diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 2eac524a65..ccded70330 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -474,13 +474,6 @@ RSpecRails/InferredSpecType: - 'spec/requests/voucher_adjustments_spec.rb' - 'spec/routing/stripe_spec.rb' -# Offense count: 1 -# Configuration parameters: IgnoreScopes, Include. -# Include: app/models/**/*.rb -Rails/InverseOf: - Exclude: - - 'app/models/spree/order.rb' - # Offense count: 35 # Configuration parameters: Include. # Include: app/controllers/**/*.rb, app/mailers/**/*.rb diff --git a/app/models/spree/order.rb b/app/models/spree/order.rb index 642b57678a..10dc76c2f0 100644 --- a/app/models/spree/order.rb +++ b/app/models/spree/order.rb @@ -43,7 +43,7 @@ module Spree has_many :state_changes, as: :stateful, dependent: :destroy has_many :line_items, -> { order('created_at ASC') - }, class_name: "Spree::LineItem", dependent: :destroy + }, class_name: "Spree::LineItem", inverse_of: :order, dependent: :destroy has_many :payments, dependent: :destroy has_many :return_authorizations, dependent: :destroy, inverse_of: :order has_many :adjustments, -> { order "#{Spree::Adjustment.table_name}.created_at ASC" }, diff --git a/spec/models/spree/order_contents_spec.rb b/spec/models/spree/order_contents_spec.rb index 19788fbeb8..7f18fe5f95 100644 --- a/spec/models/spree/order_contents_spec.rb +++ b/spec/models/spree/order_contents_spec.rb @@ -189,8 +189,8 @@ RSpec.describe Spree::OrderContents do subject.update_item(line_item, { quantity: 3 }) end - it "updates the order's enterprise fees if completed" do + order.shipments << create(:shipment) allow(order).to receive(:completed?) { true } expect(order).to receive(:update_order_fees!)