From 5ae9016f098211376df4901d6c7db873cbfacf3a Mon Sep 17 00:00:00 2001 From: Maikel Linke Date: Fri, 24 Mar 2023 14:38:06 +1100 Subject: [PATCH] Speed up spec by skipping additional page load The login_as_admin helper has to load a page to log in. Providing the page we want to go to avoids going to the default page first. --- spec/system/admin/configuration/zones_spec.rb | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/spec/system/admin/configuration/zones_spec.rb b/spec/system/admin/configuration/zones_spec.rb index 1b192f8d8a..809519da8a 100644 --- a/spec/system/admin/configuration/zones_spec.rb +++ b/spec/system/admin/configuration/zones_spec.rb @@ -6,12 +6,8 @@ describe "Zones" do include AuthenticationHelper include WebHelper - before do - login_as_admin - end - it "list existing zones" do - visit spree.edit_admin_general_settings_path + login_as_admin_and_visit spree.edit_admin_general_settings_path create(:zone, name: "eastern", description: "zone is eastern") create(:zone, name: "western", description: "cool san fran") @@ -27,7 +23,7 @@ describe "Zones" do end it "create a new zone" do - visit spree.admin_zones_path + login_as_admin_and_visit spree.admin_zones_path click_link "admin_new_zone_link" expect(page).to have_content("New Zone") @@ -40,7 +36,7 @@ describe "Zones" do it "edit existing zone" do zone = create(:zone_with_member) - visit spree.edit_admin_zone_path(zone.id) + login_as_admin_and_visit spree.edit_admin_zone_path(zone.id) expect(page).to have_checked_field "country_based"