From 595d7b55942b8ebdeb375dd1048765c3588f1fea Mon Sep 17 00:00:00 2001 From: Rob Harrington Date: Thu, 20 Jul 2017 15:47:14 +1000 Subject: [PATCH] Remove conditional assignment from PaymentsController#fire decorator --- app/controllers/spree/admin/payments_controller_decorator.rb | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/app/controllers/spree/admin/payments_controller_decorator.rb b/app/controllers/spree/admin/payments_controller_decorator.rb index cbcecd852f..92faeb093d 100644 --- a/app/controllers/spree/admin/payments_controller_decorator.rb +++ b/app/controllers/spree/admin/payments_controller_decorator.rb @@ -5,7 +5,8 @@ Spree::Admin::PaymentsController.class_eval do # When a user fires an event, take them back to where they came from # (we can't use respond_override because Spree no longer uses respond_with) def fire - return unless event = params[:e] && @payment.payment_source + event = params[:e] + return unless event && @payment.payment_source # Because we have a transition method also called void, we do this to avoid conflicts. event = "void_transaction" if event == "void"