From 56d8d1eaf725e8091c3a3ddb0fbcbe0f540fe73d Mon Sep 17 00:00:00 2001
From: Maikel Linke <maikel@email.org.au>
Date: Mon, 15 Aug 2022 17:11:51 +1000
Subject: [PATCH] Scope helper methods to relevant test cases

Global methods are usually not a good idea.
---
 .../consumer/split_checkout_tax_incl_spec.rb  | 22 +++++++++----------
 .../split_checkout_tax_not_incl_spec.rb       | 22 +++++++++----------
 2 files changed, 22 insertions(+), 22 deletions(-)

diff --git a/spec/system/consumer/split_checkout_tax_incl_spec.rb b/spec/system/consumer/split_checkout_tax_incl_spec.rb
index 8e389a3a8f..909e564a68 100644
--- a/spec/system/consumer/split_checkout_tax_incl_spec.rb
+++ b/spec/system/consumer/split_checkout_tax_incl_spec.rb
@@ -199,18 +199,18 @@ describe "As a consumer, I want to see adjustment breakdown" do
       end
     end
   end
-end
 
-private
+  private
 
-def assert_db_tax_incl
-  order_within_zone.reload
-  expect(order_within_zone.included_tax_total).to eq(1.15)
-  expect(order_within_zone.additional_tax_total).to eq(0.0)
-end
+  def assert_db_tax_incl
+    order_within_zone.reload
+    expect(order_within_zone.included_tax_total).to eq(1.15)
+    expect(order_within_zone.additional_tax_total).to eq(0.0)
+  end
 
-def assert_db_no_tax_incl
-  order_outside_zone.reload
-  expect(order_outside_zone.included_tax_total).to eq(0.0)
-  expect(order_outside_zone.additional_tax_total).to eq(0.0)
+  def assert_db_no_tax_incl
+    order_outside_zone.reload
+    expect(order_outside_zone.included_tax_total).to eq(0.0)
+    expect(order_outside_zone.additional_tax_total).to eq(0.0)
+  end
 end
diff --git a/spec/system/consumer/split_checkout_tax_not_incl_spec.rb b/spec/system/consumer/split_checkout_tax_not_incl_spec.rb
index 8358924f8b..1d6188e585 100644
--- a/spec/system/consumer/split_checkout_tax_not_incl_spec.rb
+++ b/spec/system/consumer/split_checkout_tax_not_incl_spec.rb
@@ -247,18 +247,18 @@ describe "As a consumer, I want to see adjustment breakdown" do
       end
     end
   end
-end
 
-private
+  private
 
-def assert_db_tax_added
-  order_within_zone.reload
-  expect(order_outside_zone.included_tax_total).to eq(0.0)
-  expect(order_within_zone.additional_tax_total).to eq(1.3)
-end
+  def assert_db_tax_added
+    order_within_zone.reload
+    expect(order_outside_zone.included_tax_total).to eq(0.0)
+    expect(order_within_zone.additional_tax_total).to eq(1.3)
+  end
 
-def assert_db_no_tax_added
-  order_outside_zone.reload
-  expect(order_outside_zone.included_tax_total).to eq(0.0)
-  expect(order_outside_zone.additional_tax_total).to eq(0.0)
+  def assert_db_no_tax_added
+    order_outside_zone.reload
+    expect(order_outside_zone.included_tax_total).to eq(0.0)
+    expect(order_outside_zone.additional_tax_total).to eq(0.0)
+  end
 end