From 55ece0553c0f8466e86a16efcbd02a6beb005bb0 Mon Sep 17 00:00:00 2001 From: David Cook Date: Mon, 29 Apr 2024 16:24:58 +1000 Subject: [PATCH] Revert. JS is still required for most specs But models can still run without. Half of the controller runs also succeeded, so we could potentially separate those ones out. Hmm, yes only 7 of them. It would save 20s, or 16% of controller CI runtimesi which are 2min. let's try.. --- .github/workflows/build.yml | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 8227c72557..1b553c7b74 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -55,6 +55,14 @@ jobs: with: bundler-cache: true # runs 'bundle install' and caches installed gems automatically + # JS is required in order for webpacker to compile, in order to render templates containing image urls + - uses: actions/setup-node@v3 + with: + node-version-file: .node-version + + - name: Install JS dependencies + run: yarn install --frozen-lockfile + - name: Set up database run: | bundle exec rake db:create db:schema:load @@ -328,6 +336,14 @@ jobs: with: bundler-cache: true # runs 'bundle install' and caches installed gems automatically + # JS is required in order for webpacker to compile, in order to render templates linking to mail.css + - uses: actions/setup-node@v3 + with: + node-version-file: .node-version + + - name: Install JS dependencies + run: yarn install --frozen-lockfile + - name: Set up database run: | bundle exec rake db:create db:schema:load @@ -398,6 +414,14 @@ jobs: with: bundler-cache: true # runs 'bundle install' and caches installed gems automatically + # JS is required in order for webpacker to compile, in order to render templates linking to mail.css + - uses: actions/setup-node@v3 + with: + node-version-file: .node-version + + - name: Install JS dependencies + run: yarn install --frozen-lockfile + - name: Set up database run: | bundle exec rake db:create db:schema:load