From 55b3f4d54ffc76182d56a7453e335de68f5a2b25 Mon Sep 17 00:00:00 2001 From: Luis Ramos Date: Fri, 3 Apr 2020 19:47:33 +0100 Subject: [PATCH] Move search params test case to a different context so that we dont have to set the producer of the products in the order This is working in master by chance of the factories but breaks in rails 4 because the orders in this test dont have products supplied by the producer which is a necessary condition in the context where it was --- spec/services/permissions/order_spec.rb | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/spec/services/permissions/order_spec.rb b/spec/services/permissions/order_spec.rb index d60d6968e2..88e3666aca 100644 --- a/spec/services/permissions/order_spec.rb +++ b/spec/services/permissions/order_spec.rb @@ -47,6 +47,18 @@ module Permissions it "should let me see the order" do expect(permissions.visible_orders).to include order end + + context "with search params" do + let(:search_params) { { completed_at_gt: Time.zone.now.yesterday.strftime('%Y-%m-%d') } } + let(:permissions) { Permissions::Order.new(user, search_params) } + + it "only returns completed, non-cancelled orders within search filter range" do + expect(permissions.visible_orders).to include order_completed + expect(permissions.visible_orders).to_not include order_cancelled + expect(permissions.visible_orders).to_not include order_cart + expect(permissions.visible_orders).to_not include order_from_last_year + end + end end context "as a producer which has granted P-OC to the distributor of an order" do @@ -71,18 +83,6 @@ module Permissions expect(permissions.visible_orders).to_not include order end end - - context "with search params" do - let(:search_params) { { completed_at_gt: Time.zone.now.yesterday.strftime('%Y-%m-%d') } } - let(:permissions) { Permissions::Order.new(user, search_params) } - - it "only returns completed, non-cancelled orders within search filter range" do - expect(permissions.visible_orders).to include order_completed - expect(permissions.visible_orders).to_not include order_cancelled - expect(permissions.visible_orders).to_not include order_cart - expect(permissions.visible_orders).to_not include order_from_last_year - end - end end context "as an enterprise that is a distributor in the order cycle, but not the distributor of the order" do