From 548ffc0222821860a54ea02bffa8bd421cb8f1c6 Mon Sep 17 00:00:00 2001 From: Ahmed Ejaz Date: Thu, 28 Dec 2023 17:28:26 +0500 Subject: [PATCH] 11068: replace p tag with a tag --- app/components/vertical_ellipsis_menu/component.scss | 3 +-- app/views/admin/products_v3/_table.html.haml | 4 ++-- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/app/components/vertical_ellipsis_menu/component.scss b/app/components/vertical_ellipsis_menu/component.scss index 7730b384ce..03b5cb39d8 100644 --- a/app/components/vertical_ellipsis_menu/component.scss +++ b/app/components/vertical_ellipsis_menu/component.scss @@ -30,8 +30,7 @@ display: block; } - & > a, - p { + & > a { display: block; padding: 5px 10px; cursor: pointer; diff --git a/app/views/admin/products_v3/_table.html.haml b/app/views/admin/products_v3/_table.html.haml index 9901a5a3d4..5573561121 100644 --- a/app/views/admin/products_v3/_table.html.haml +++ b/app/views/admin/products_v3/_table.html.haml @@ -70,7 +70,7 @@ = render(VerticalEllipsisMenu::Component.new) do = link_to t('admin.products_page.actions.edit'), edit_admin_product_path(product) = link_to t('admin.products_page.actions.clone'), clone_admin_product_path(product) - %p{ "data-controller": "modal-link product-actions", "data-action": "click->product-actions#setDeleteModalDataSet click->modal-link#open", + %a{ "data-controller": "modal-link product-actions", "data-action": "click->product-actions#setDeleteModalDataSet click->modal-link#open", "data-modal-link-target-value": "product-delete-modal", "class": "delete", "data-product-actions-id-value": product.id } = t('admin.products_page.actions.delete') @@ -112,6 +112,6 @@ = render(VerticalEllipsisMenu::Component.new) do = link_to t('admin.products_page.actions.edit'), edit_admin_product_variant_path(product, variant) - if product.variants.size > 1 - %p{ "data-controller": "modal-link product-actions", "data-action": "click->product-actions#setDeleteModalDataSet click->modal-link#open", + %a{ "data-controller": "modal-link product-actions", "data-action": "click->product-actions#setDeleteModalDataSet click->modal-link#open", "data-modal-link-target-value": "variant-delete-modal", "class": "delete", "data-product-actions-id-value": variant.id } = t('admin.products_page.actions.delete')