From 52d82d0a96e7d34fc68627e01fab661c203e672c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fran=C3=A7ois=20Turbelin?= Date: Thu, 3 Sep 2020 00:59:21 +0200 Subject: [PATCH] Use not found instead of 404 for spec descriptions --- .../dfc_provider/api/catalog_items_controller_spec.rb | 4 ++-- .../spec/controllers/dfc_provider/api/enterprises_spec.rb | 2 +- .../controllers/dfc_provider/api/persons_controller_spec.rb | 2 +- .../dfc_provider/api/supplied_products_controller_spec.rb | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/engines/dfc_provider/spec/controllers/dfc_provider/api/catalog_items_controller_spec.rb b/engines/dfc_provider/spec/controllers/dfc_provider/api/catalog_items_controller_spec.rb index 7b5d42865a..c3637b0f1e 100644 --- a/engines/dfc_provider/spec/controllers/dfc_provider/api/catalog_items_controller_spec.rb +++ b/engines/dfc_provider/spec/controllers/dfc_provider/api/catalog_items_controller_spec.rb @@ -73,7 +73,7 @@ describe DfcProvider::Api::CatalogItemsController, type: :controller do context 'without a recorded enterprise' do let(:enterprise) { create(:enterprise) } - it 'returns not_found head' do + it 'is not found' do api_get :index, enterprise_id: 'default' expect(response.status).to eq 404 end @@ -140,7 +140,7 @@ describe DfcProvider::Api::CatalogItemsController, type: :controller do id: create(:simple_product).variants.first.id end - it 'returns a 404 error' do + it 'is not found' do expect(response.status).to eq 404 end end diff --git a/engines/dfc_provider/spec/controllers/dfc_provider/api/enterprises_spec.rb b/engines/dfc_provider/spec/controllers/dfc_provider/api/enterprises_spec.rb index 691fcb4e0e..27cb0b6311 100644 --- a/engines/dfc_provider/spec/controllers/dfc_provider/api/enterprises_spec.rb +++ b/engines/dfc_provider/spec/controllers/dfc_provider/api/enterprises_spec.rb @@ -43,7 +43,7 @@ describe DfcProvider::Api::EnterprisesController, type: :controller do context 'given with a wrong id' do before { api_get :show, id: 999 } - it 'returns 404' do + it 'is not found' do expect(response.status).to eq 404 end end diff --git a/engines/dfc_provider/spec/controllers/dfc_provider/api/persons_controller_spec.rb b/engines/dfc_provider/spec/controllers/dfc_provider/api/persons_controller_spec.rb index 0098061591..617c6d08ec 100644 --- a/engines/dfc_provider/spec/controllers/dfc_provider/api/persons_controller_spec.rb +++ b/engines/dfc_provider/spec/controllers/dfc_provider/api/persons_controller_spec.rb @@ -38,7 +38,7 @@ describe DfcProvider::Api::PersonsController, type: :controller do context 'with an other user id' do before { api_get :show, id: create(:user).id } - it 'returns 404' do + it 'is not found' do expect(response.status).to eq 404 end end diff --git a/engines/dfc_provider/spec/controllers/dfc_provider/api/supplied_products_controller_spec.rb b/engines/dfc_provider/spec/controllers/dfc_provider/api/supplied_products_controller_spec.rb index de594d276d..98bee69055 100644 --- a/engines/dfc_provider/spec/controllers/dfc_provider/api/supplied_products_controller_spec.rb +++ b/engines/dfc_provider/spec/controllers/dfc_provider/api/supplied_products_controller_spec.rb @@ -44,7 +44,7 @@ describe DfcProvider::Api::SuppliedProductsController, type: :controller do context 'given with a wrong id' do before { api_get :show, id: 999 } - it 'returns 404' do + it 'is not found' do expect(response.status).to eq 404 end end