From 51e277a18331af8dbaeebfab7857d210c862d2f6 Mon Sep 17 00:00:00 2001 From: Pau Perez Date: Fri, 14 Dec 2018 15:12:41 +0100 Subject: [PATCH] Make test setup more readable --- .../enterprise_serializer_spec.rb | 35 ++++++++++++------- 1 file changed, 23 insertions(+), 12 deletions(-) diff --git a/spec/serializers/admin/for_order_cycle/enterprise_serializer_spec.rb b/spec/serializers/admin/for_order_cycle/enterprise_serializer_spec.rb index c30b6374c9..025a04f23c 100644 --- a/spec/serializers/admin/for_order_cycle/enterprise_serializer_spec.rb +++ b/spec/serializers/admin/for_order_cycle/enterprise_serializer_spec.rb @@ -1,16 +1,27 @@ describe Api::Admin::ForOrderCycle::EnterpriseSerializer do - let(:coordinator) { create(:distributor_enterprise) } - let(:order_cycle) { double(:order_cycle, coordinator: coordinator) } - let(:enterprise) { create(:distributor_enterprise) } - let!(:non_inventory_product) { create(:simple_product, supplier: enterprise) } - let!(:non_inventory_variant) { non_inventory_product.variants.first } - let!(:inventory_product) { create(:simple_product, supplier: enterprise) } - let!(:inventory_variant) { inventory_product.variants.first } - let!(:deleted_product) { create(:simple_product, supplier: enterprise, deleted_at: 24.hours.ago ) } - let!(:deleted_variant) { deleted_product.variants.first } - let(:serialized_enterprise) { Api::Admin::ForOrderCycle::EnterpriseSerializer.new(enterprise, order_cycle: order_cycle, spree_current_user: enterprise.owner ).to_json } - let!(:inventory_item1) { create(:inventory_item, enterprise: coordinator, variant: inventory_variant, visible: true)} - let!(:inventory_item2) { create(:inventory_item, enterprise: coordinator, variant: deleted_variant, visible: true)} + let(:coordinator) { create(:distributor_enterprise) } + let(:order_cycle) { double(:order_cycle, coordinator: coordinator) } + let(:enterprise) { create(:distributor_enterprise) } + + let(:non_inventory_product) { create(:simple_product, supplier: enterprise) } + let!(:non_inventory_variant) { non_inventory_product.variants.first } + + let(:inventory_product) { create(:simple_product, supplier: enterprise) } + let(:inventory_variant) { inventory_product.variants.first } + + let(:deleted_product) { create(:product, supplier: enterprise, deleted_at: 24.hours.ago ) } + let(:deleted_variant) { deleted_product.variants.first } + + let(:serialized_enterprise) do + Api::Admin::ForOrderCycle::EnterpriseSerializer.new( + enterprise, + order_cycle: order_cycle, + spree_current_user: enterprise.owner + ).to_json + end + + let!(:inventory_item1) { create(:inventory_item, enterprise: coordinator, variant: inventory_variant, visible: true) } + let!(:inventory_item2) { create(:inventory_item, enterprise: coordinator, variant: deleted_variant, visible: true) } context "when order cycle shows only variants in the coordinator's inventory" do before do