From 50e87a023b640fdaaf1ce649aa209dba70065154 Mon Sep 17 00:00:00 2001 From: Andy Brett Date: Thu, 10 Dec 2020 07:45:07 -0800 Subject: [PATCH] rename method to `validate!` since it can raise an error --- app/models/spree/payment/processing.rb | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/app/models/spree/payment/processing.rb b/app/models/spree/payment/processing.rb index 0b2daa4bc9..36704362a8 100644 --- a/app/models/spree/payment/processing.rb +++ b/app/models/spree/payment/processing.rb @@ -4,7 +4,7 @@ module Spree class Payment < ActiveRecord::Base module Processing def process! - return unless ready_to_process? + return unless validate! if payment_method.auto_capture? purchase! @@ -14,7 +14,7 @@ module Spree end def process_offline! - return unless ready_to_process? + return unless validate! if payment_method.auto_capture? charge_offline! @@ -199,7 +199,7 @@ module Spree private - def ready_to_process? + def validate! return false unless payment_method&.source_required? raise Core::GatewayError, Spree.t(:payment_processing_failed) unless source