From 507fa028c149d8a57dfe7cc8a49e906157ffbc99 Mon Sep 17 00:00:00 2001 From: Gaetan Craig-Riou Date: Wed, 13 Mar 2024 16:30:31 +1100 Subject: [PATCH] Fix api admin serializers --- app/serializers/api/admin/product_serializer.rb | 2 -- app/serializers/api/admin/variant_serializer.rb | 3 ++- spec/serializers/api/admin/product_serializer_spec.rb | 2 +- 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/app/serializers/api/admin/product_serializer.rb b/app/serializers/api/admin/product_serializer.rb index 356c0debdf..836b78bdaa 100644 --- a/app/serializers/api/admin/product_serializer.rb +++ b/app/serializers/api/admin/product_serializer.rb @@ -7,8 +7,6 @@ module Api :inherits_properties, :on_hand, :price, :import_date, :image_url, :thumb_url, :variants - has_one :supplier, key: :producer_id, embed: :id - def variants ActiveModel::ArraySerializer.new( object.variants, diff --git a/app/serializers/api/admin/variant_serializer.rb b/app/serializers/api/admin/variant_serializer.rb index 06732aa7b5..5ccb8347c7 100644 --- a/app/serializers/api/admin/variant_serializer.rb +++ b/app/serializers/api/admin/variant_serializer.rb @@ -9,6 +9,7 @@ module Api :price, :on_demand, :on_hand, :in_stock, :stock_location_id, :stock_location_name has_one :primary_taxon, key: :category_id, embed: :id + has_one :supplier, key: :producer_id, embed: :id def name if object.full_name.present? @@ -31,7 +32,7 @@ module Api end def producer_name - object.product.supplier.name + object.supplier.name end def image diff --git a/spec/serializers/api/admin/product_serializer_spec.rb b/spec/serializers/api/admin/product_serializer_spec.rb index d2c0f25577..8cbb0a63ec 100644 --- a/spec/serializers/api/admin/product_serializer_spec.rb +++ b/spec/serializers/api/admin/product_serializer_spec.rb @@ -3,7 +3,7 @@ require 'spec_helper' RSpec.describe Api::Admin::ProductSerializer do - let(:product) { create(:simple_product) } + let(:product) { create(:simple_product, supplier_id: create(:supplier_enterprise).id) } let(:serializer) { described_class.new(product) } it "serializes a product" do