diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index e383738009..61b7c72f9d 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,19 +1,11 @@ # This configuration was generated by # `rubocop --auto-gen-config --exclude-limit 1400` -# on 2021-03-25 06:59:27 UTC using RuboCop version 1.12.0. +# on 2021-06-17 21:32:23 UTC using RuboCop version 1.17.0. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new # versions of RuboCop, may require this file to be generated again. -# Offense count: 2 -# Cop supports --auto-correct. -# Configuration parameters: TreatCommentsAsGroupSeparators, ConsiderPunctuation, Include. -# Include: **/*.gemfile, **/Gemfile, **/gems.rb -Bundler/OrderedGems: - Exclude: - - 'Gemfile' - # Offense count: 4 # Configuration parameters: Include. # Include: **/*.gemspec @@ -24,170 +16,12 @@ Gemspec/RequiredRubyVersion: - 'engines/order_management/order_management.gemspec' - 'engines/web/web.gemspec' -# Offense count: 2 +# Offense count: 25 # Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, IndentationWidth. -# SupportedStyles: with_first_argument, with_fixed_indentation -Layout/ArgumentAlignment: - Exclude: - - 'spec/features/admin/order_cycles/simple_spec.rb' - -# Offense count: 5 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyleAlignWith, Severity. -# SupportedStylesAlignWith: start_of_line, begin -Layout/BeginEndAlignment: - Exclude: - - 'app/controllers/application_controller.rb' - - 'app/controllers/spree/admin/reports_controller.rb' - - 'app/jobs/job_logger.rb' - - 'app/models/spree/address.rb' - - 'app/models/spree/credit_card.rb' - -# Offense count: 2 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyleAlignWith. -# SupportedStylesAlignWith: either, start_of_block, start_of_line -Layout/BlockAlignment: - Exclude: - - 'spec/features/admin/order_cycles/complex_creating_specific_time_spec.rb' - - 'spec/features/admin/order_cycles/simple_spec.rb' - -# Offense count: 2 -# Cop supports --auto-correct. -Layout/CommentIndentation: - Exclude: - - 'spec/features/admin/order_cycles/simple_spec.rb' - -# Offense count: 1 -# Cop supports --auto-correct. -Layout/EmptyLineAfterMagicComment: - Exclude: - - 'spec/features/admin/configuration/tax_rates_spec.rb' - -# Offense count: 2 -# Cop supports --auto-correct. -# Configuration parameters: EmptyLineBetweenMethodDefs, EmptyLineBetweenClassDefs, EmptyLineBetweenModuleDefs, AllowAdjacentOneLineDefs, NumberOfEmptyLines. -Layout/EmptyLineBetweenDefs: - Exclude: - - 'app/controllers/api/enterprise_attachment_controller.rb' - - 'spec/controllers/spree/admin/base_controller_spec.rb' - -# Offense count: 1 -# Cop supports --auto-correct. -Layout/EmptyLines: - Exclude: - - 'spec/controllers/spree/admin/reports_controller_spec.rb' - -# Offense count: 5 -# Cop supports --auto-correct. -# Configuration parameters: AllowAliasSyntax, AllowedMethods. -# AllowedMethods: alias_method, public, protected, private -Layout/EmptyLinesAroundAttributeAccessor: - Exclude: - - 'app/models/spree/shipment.rb' - - 'lib/open_food_network/customers_report.rb' - - 'lib/open_food_network/packing_report.rb' - - 'lib/open_food_network/payments_report.rb' - - 'lib/open_food_network/users_and_enterprises_report.rb' - -# Offense count: 1 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle. -# SupportedStyles: empty_lines, no_empty_lines -Layout/EmptyLinesAroundBlockBody: - Exclude: - - 'spec/features/admin/payment_method_spec.rb' - -# Offense count: 4 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, IndentationWidth. -# SupportedStyles: special_inside_parentheses, consistent, align_brackets -Layout/FirstArrayElementIndentation: - Exclude: - - 'spec/lib/open_food_network/order_cycle_management_report_spec.rb' - -# Offense count: 7 -# Cop supports --auto-correct. -# Configuration parameters: AllowMultipleStyles, EnforcedHashRocketStyle, EnforcedColonStyle, EnforcedLastArgumentHashStyle. -# SupportedHashRocketStyles: key, separator, table -# SupportedColonStyles: key, separator, table -# SupportedLastArgumentHashStyles: always_inspect, always_ignore, ignore_implicit, ignore_explicit -Layout/HashAlignment: - Exclude: - - 'app/controllers/admin/order_cycles_controller.rb' - - 'spec/features/admin/adjustments_spec.rb' - - 'spec/models/spree/adjustment_spec.rb' - - 'spec/models/spree/order_spec.rb' - -# Offense count: 1 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle. -# SupportedStyles: normal, indented_internal_methods -Layout/IndentationConsistency: - Exclude: - - 'spec/features/admin/order_cycles/complex_creating_specific_time_spec.rb' - -# Offense count: 2 -# Cop supports --auto-correct. -Layout/MultilineBlockLayout: - Exclude: - - 'spec/controllers/spree/orders_controller_spec.rb' - - 'spec/services/process_payment_intent_spec.rb' - -# Offense count: 2 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle. -# SupportedStyles: symmetrical, new_line, same_line -Layout/MultilineMethodCallBraceLayout: - Exclude: - - 'spec/controllers/spree/orders_controller_spec.rb' - - 'spec/services/process_payment_intent_spec.rb' - -# Offense count: 4 -# Cop supports --auto-correct. -Layout/RescueEnsureAlignment: - Exclude: - - 'app/controllers/application_controller.rb' - - 'app/controllers/spree/admin/reports_controller.rb' - - 'app/models/spree/address.rb' - - 'app/models/spree/credit_card.rb' - -# Offense count: 2 -# Cop supports --auto-correct. -Layout/SpaceAroundMethodCallOperator: - Exclude: - - 'spec/controllers/api/orders_controller_spec.rb' - - 'spec/controllers/api/shipments_controller_spec.rb' - -# Offense count: 2 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBrackets. -# SupportedStyles: space, no_space, compact -# SupportedStylesForEmptyBrackets: space, no_space -Layout/SpaceInsideArrayLiteralBrackets: - Exclude: - - 'spec/controllers/spree/admin/reports_controller_spec.rb' - -# Offense count: 4 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces. -# SupportedStyles: space, no_space, compact -# SupportedStylesForEmptyBraces: space, no_space -Layout/SpaceInsideHashLiteralBraces: - Exclude: - - 'spec/services/embedded_page_service_spec.rb' - -# Offense count: 10 -# Cop supports --auto-correct. -# Configuration parameters: AllowInHeredoc. -Layout/TrailingWhitespace: - Exclude: - - 'spec/features/admin/order_cycles/simple_spec.rb' - - 'spec/features/consumer/shopping/unit_price_spec.rb' - - 'spec/support/features/datepicker_helper.rb' - - 'spec/support/request/web_helper.rb' - - 'spec/views/spree/orders/edit.html.haml_spec.rb' +# Configuration parameters: AutoCorrect, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns. +# URISchemes: http, https +Layout/LineLength: + Max: 148 # Offense count: 15 # Configuration parameters: AllowedMethods. @@ -222,12 +56,16 @@ Lint/FloatComparison: - 'app/models/product_import/entry_validator.rb' - 'app/models/spree/gateway/pay_pal_express.rb' -# Offense count: 5 +# Offense count: 1 Lint/IneffectiveAccessModifier: Exclude: - - 'app/models/column_preference.rb' - 'app/models/spree/user.rb' - - 'app/services/mail_configuration.rb' + +# Offense count: 2 +Lint/MissingSuper: + Exclude: + - 'app/components/distributor_title_component.rb' + - 'app/components/example_component.rb' # Offense count: 1 # Cop supports --auto-correct. @@ -238,18 +76,9 @@ Lint/RedundantSafeNavigation: - 'app/models/spree/payment.rb' # Offense count: 1 -# Cop supports --auto-correct. -Lint/ScriptPermission: +Lint/UselessAssignment: Exclude: - - '.simplecov' - -# Offense count: 2 -# Cop supports --auto-correct. -# Configuration parameters: ContextCreatingMethods, MethodCreatingMethods. -Lint/UselessAccessModifier: - Exclude: - - 'app/models/column_preference.rb' - - 'app/services/mail_configuration.rb' + - 'app/models/spree/credit_card.rb' # Offense count: 5 # Cop supports --auto-correct. @@ -259,12 +88,48 @@ Lint/UselessMethodDefinition: - 'app/controllers/spree/user_registrations_controller.rb' - 'app/models/spree/gateway.rb' +# Offense count: 13 +# Configuration parameters: IgnoredMethods, CountRepeatedAttributes. +Metrics/AbcSize: + Max: 25 + +# Offense count: 3 +# Configuration parameters: CountComments, CountAsOne, ExcludedMethods, IgnoredMethods. +# IgnoredMethods: refine +Metrics/BlockLength: + Max: 30 + +# Offense count: 3 +# Configuration parameters: CountComments, CountAsOne. +Metrics/ClassLength: + Max: 122 + +# Offense count: 1 +# Configuration parameters: IgnoredMethods. +Metrics/CyclomaticComplexity: + Max: 9 + +# Offense count: 10 +# Configuration parameters: CountComments, CountAsOne, ExcludedMethods, IgnoredMethods. +Metrics/MethodLength: + Max: 17 + +# Offense count: 2 +# Configuration parameters: CountComments, CountAsOne. +Metrics/ModuleLength: + Max: 369 + # Offense count: 2 # Configuration parameters: Max, CountKeywordArgs. Metrics/ParameterLists: MaxOptionalParameters: 4 -# Offense count: 10 +# Offense count: 3 +# Configuration parameters: IgnoredMethods. +Metrics/PerceivedComplexity: + Max: 10 + +# Offense count: 9 Naming/AccessorMethodName: Exclude: - 'app/controllers/spree/admin/taxonomies_controller.rb' @@ -282,42 +147,23 @@ Naming/HeredocDelimiterNaming: Exclude: - 'app/models/content_configuration.rb' -# Offense count: 4 +# Offense count: 5 # Configuration parameters: EnforcedStyleForLeadingUnderscores. # SupportedStylesForLeadingUnderscores: disallowed, required, optional Naming/MemoizedInstanceVariableName: Exclude: - 'app/mailers/producer_mailer.rb' + - 'app/models/concerns/balance.rb' - 'lib/open_food_network/address_finder.rb' -# Offense count: 23 -# Configuration parameters: NamePrefix, ForbiddenPrefixes, AllowedMethods, MethodDefinitionMacros. -# NamePrefix: is_, has_, have_ -# ForbiddenPrefixes: is_, has_, have_ -# AllowedMethods: is_a? -# MethodDefinitionMacros: define_method, define_singleton_method -Naming/PredicateName: +# Offense count: 1 +# Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames. +# AllowedNames: at, by, db, id, in, io, ip, of, on, os, pp, to +Naming/MethodParameterName: Exclude: - - 'app/models/enterprise.rb' - - 'app/models/enterprise_relationship.rb' - - 'app/models/order_cycle.rb' - - 'app/models/spree/ability.rb' - - 'app/models/spree/adjustment.rb' - - 'app/models/spree/credit_card.rb' - - 'app/models/spree/line_item.rb' - - 'app/models/spree/order.rb' - - 'app/models/spree/payment_method.rb' - - 'app/models/spree/preferences/file_configuration.rb' - - 'app/models/spree/preferences/preferable.rb' - - 'app/models/spree/shipping_method.rb' - - 'app/models/spree/user.rb' - - 'lib/open_food_network/customers_report.rb' - - 'lib/open_food_network/order_cycle_management_report.rb' - - 'lib/open_food_network/order_grouper.rb' - - 'lib/open_food_network/packing_report.rb' - - 'lib/tasks/data.rake' + - 'app/services/process_payment_intent.rb' -# Offense count: 30 +# Offense count: 34 # Configuration parameters: EnforcedStyle, CheckMethodNames, CheckSymbols, AllowedIdentifiers. # SupportedStyles: snake_case, normalcase, non_integer # AllowedIdentifiers: capture3, iso8601, rfc1123_date, rfc822, rfc2822, rfc3339 @@ -332,18 +178,21 @@ Naming/VariableNumber: - 'spec/factories/stock_location_factory.rb' - 'spec/features/admin/reports_spec.rb' - 'spec/models/spree/stock_item_spec.rb' + - 'spec/models/spree/tax_rate_spec.rb' - 'spec/requests/api/orders_spec.rb' -# Offense count: 9 +# Offense count: 2 # Cop supports --auto-correct. Rails/ActiveRecordAliases: Exclude: - - 'app/models/spree/gateway/pay_pal_express.rb' - - 'spec/controllers/line_items_controller_spec.rb' - - 'spec/controllers/spree/orders_controller_spec.rb' - - 'spec/features/admin/subscriptions_spec.rb' - - 'spec/features/consumer/shopping/orders_spec.rb' - - 'spec/requests/api/orders_spec.rb' + - 'app/models/spree/order_contents.rb' + +# Offense count: 1 +# Configuration parameters: Include. +# Include: app/models/**/*.rb +Rails/ActiveRecordOverride: + Exclude: + - 'app/models/spree/product.rb' # Offense count: 1 # Cop supports --auto-correct. @@ -351,12 +200,11 @@ Rails/ApplicationController: Exclude: - 'engines/dfc_provider/app/controllers/dfc_provider/api/base_controller.rb' -# Offense count: 6 +# Offense count: 5 # Cop supports --auto-correct. Rails/ApplicationJob: Exclude: - 'app/jobs/bulk_invoice_job.rb' - - 'app/jobs/confirm_order_job.rb' - 'app/jobs/heartbeat_job.rb' - 'app/jobs/order_cycle_notification_job.rb' - 'app/jobs/subscription_confirm_job.rb' @@ -368,12 +216,21 @@ Rails/ApplicationMailer: Exclude: - 'app/mailers/spree/base_mailer.rb' -# Offense count: 3 +# Offense count: 1 +# Cop supports --auto-correct. +Rails/ApplicationRecord: + Exclude: + - 'lib/tasks/data/remove_transient_data.rb' + +# Offense count: 6 # Cop supports --auto-correct. # Configuration parameters: NilOrEmpty, NotPresent, UnlessPresent. Rails/Blank: Exclude: + - 'app/jobs/subscription_placement_job.rb' + - 'app/models/spree/order_contents.rb' - 'app/services/content_sanitizer.rb' + - 'engines/order_management/app/services/order_management/stock/package.rb' - 'lib/stripe/authorize_response_patcher.rb' # Offense count: 3 @@ -384,14 +241,6 @@ Rails/Date: - 'app/models/order_cycle.rb' - 'app/models/spree/credit_card.rb' -# Offense count: 2 -# Cop supports --auto-correct. -# Configuration parameters: EnforceForPrefixed. -Rails/Delegate: - Exclude: - - 'app/models/spree/line_item.rb' - - 'engines/order_management/app/services/order_management/reports/bulk_coop/renderers/html_renderer.rb' - # Offense count: 15 # Configuration parameters: EnforcedStyle. # SupportedStyles: slashes, arguments @@ -399,10 +248,10 @@ Rails/FilePath: Exclude: - 'app/models/product_import/product_importer.rb' - 'lib/tasks/karma.rake' - - 'spec/controllers/api/logos_controller_spec.rb' - - 'spec/controllers/api/product_images_controller_spec.rb' - - 'spec/controllers/api/promo_images_controller_spec.rb' - - 'spec/controllers/api/terms_and_conditions_controller_spec.rb' + - 'spec/controllers/api/v0/logos_controller_spec.rb' + - 'spec/controllers/api/v0/product_images_controller_spec.rb' + - 'spec/controllers/api/v0/promo_images_controller_spec.rb' + - 'spec/controllers/api/v0/terms_and_conditions_controller_spec.rb' - 'spec/factories/product_factory.rb' - 'spec/features/admin/enterprises/images_spec.rb' - 'spec/models/content_configuration_spec.rb' @@ -437,7 +286,7 @@ Rails/HasAndBelongsToMany: - 'app/models/spree/variant.rb' - 'app/models/spree/zone.rb' -# Offense count: 41 +# Offense count: 42 # Configuration parameters: Include. # Include: app/models/**/*.rb Rails/HasManyOrHasOneDependent: @@ -456,6 +305,7 @@ Rails/HasManyOrHasOneDependent: - 'app/models/spree/shipping_category.rb' - 'app/models/spree/shipping_method.rb' - 'app/models/spree/stock_item.rb' + - 'app/models/spree/tax_rate.rb' - 'app/models/spree/taxonomy.rb' - 'app/models/spree/user.rb' - 'app/models/spree/variant.rb' @@ -475,31 +325,31 @@ Rails/HelperInstanceVariable: - 'app/helpers/spree/admin/orders_helper.rb' - 'app/helpers/spree/orders_helper.rb' -# Offense count: 38 +# Offense count: 35 # Configuration parameters: Include. # Include: app/models/**/*.rb Rails/InverseOf: Exclude: - - 'app/models/concerns/line_item_based_adjustment_handling.rb' - - 'app/models/customer.rb' - 'app/models/enterprise.rb' - - 'app/models/enterprise_fee.rb' - 'app/models/order_cycle.rb' - 'app/models/spree/adjustment.rb' - 'app/models/spree/country.rb' - 'app/models/spree/credit_card.rb' + - 'app/models/spree/inventory_unit.rb' - 'app/models/spree/line_item.rb' - 'app/models/spree/option_type.rb' - 'app/models/spree/order.rb' - 'app/models/spree/payment.rb' + - 'app/models/spree/price.rb' - 'app/models/spree/product.rb' - 'app/models/spree/shipment.rb' + - 'app/models/spree/stock_item.rb' + - 'app/models/spree/tax_rate.rb' - 'app/models/spree/taxonomy.rb' - - 'app/models/spree/user.rb' - 'app/models/spree/variant.rb' - - 'app/models/subscription.rb' + - 'app/models/subscription_line_item.rb' -# Offense count: 35 +# Offense count: 39 # Configuration parameters: Include. # Include: app/controllers/**/*.rb Rails/LexicallyScopedActionFilter: @@ -516,6 +366,7 @@ Rails/LexicallyScopedActionFilter: - 'app/controllers/spree/admin/payment_methods_controller.rb' - 'app/controllers/spree/admin/payments_controller.rb' - 'app/controllers/spree/admin/products_controller.rb' + - 'app/controllers/spree/admin/return_authorizations_controller.rb' - 'app/controllers/spree/admin/search_controller.rb' - 'app/controllers/spree/admin/shipping_methods_controller.rb' - 'app/controllers/spree/admin/users_controller.rb' @@ -537,41 +388,14 @@ Rails/OutputSafety: - 'lib/spree/money.rb' - 'spec/features/admin/order_print_ticket_spec.rb' -# Offense count: 2 +# Offense count: 1 # Cop supports --auto-correct. -Rails/PluralizationGrammar: +# Configuration parameters: AutoCorrect. +Rails/RelativeDateConstant: Exclude: - - 'spec/queries/complete_orders_with_balance_spec.rb' + - 'lib/tasks/data/remove_transient_data.rb' -# Offense count: 3 -# Cop supports --auto-correct. -# Configuration parameters: Include. -# Include: **/Rakefile, **/*.rake -Rails/RakeEnvironment: - Exclude: - - 'lib/tasks/specs.rake' - -# Offense count: 14 -# Cop supports --auto-correct. -Rails/RedundantForeignKey: - Exclude: - - 'app/models/customer.rb' - - 'app/models/enterprise.rb' - - 'app/models/enterprise_fee.rb' - - 'app/models/enterprise_group.rb' - - 'app/models/spree/order.rb' - - 'app/models/spree/shipping_method.rb' - - 'app/models/spree/user.rb' - - 'app/models/subscription.rb' - -# Offense count: 4 -Rails/ReflectionClassName: - Exclude: - - 'app/models/customer.rb' - - 'app/models/enterprise_role.rb' - - 'app/models/spree/order.rb' - -# Offense count: 284 +# Offense count: 301 # Configuration parameters: ForbiddenMethods, AllowedMethods. # ForbiddenMethods: decrement!, decrement_counter, increment!, increment_counter, insert, insert!, insert_all, insert_all!, toggle!, touch, touch_all, update_all, update_attribute, update_column, update_columns, update_counters, upsert, upsert_all Rails/SkipsModelValidations: @@ -589,10 +413,13 @@ Rails/SkipsModelValidations: - 'app/models/product_import/inventory_reset_strategy.rb' - 'app/models/proxy_order.rb' - 'app/models/spree/address.rb' + - 'app/models/spree/adjustment.rb' - 'app/models/spree/credit_card.rb' - 'app/models/spree/gateway/pay_pal_express.rb' - 'app/models/spree/inventory_unit.rb' + - 'app/models/spree/item_adjustments.rb' - 'app/models/spree/order.rb' + - 'app/models/spree/order/checkout.rb' - 'app/models/spree/payment.rb' - 'app/models/spree/product.rb' - 'app/models/spree/shipment.rb' @@ -604,28 +431,30 @@ Rails/SkipsModelValidations: - 'app/models/subscription.rb' - 'app/models/variant_override.rb' - 'app/services/order_factory.rb' - - 'app/services/process_payment_intent.rb' - 'engines/order_management/app/services/order_management/order/updater.rb' - 'engines/order_management/spec/services/order_management/reports/enterprise_fee_summary/report_service_spec.rb' - 'engines/order_management/spec/services/order_management/subscriptions/stripe_payment_setup_spec.rb' - - 'lib/spree/core/calculated_adjustments.rb' + - 'lib/spree/core/controller_helpers/order.rb' - 'lib/tasks/data/anonymize_data.rake' - 'lib/tasks/sample_data/product_factory.rb' - 'lib/tasks/users.rake' + - 'spec/controllers/admin/bulk_line_items_controller_spec.rb' - 'spec/controllers/admin/customers_controller_spec.rb' - 'spec/controllers/admin/subscription_line_items_controller_spec.rb' - 'spec/controllers/admin/variant_overrides_controller_spec.rb' - - 'spec/controllers/api/order_cycles_controller_spec.rb' - - 'spec/controllers/api/orders_controller_spec.rb' - - 'spec/controllers/api/products_controller_spec.rb' - - 'spec/controllers/api/shipments_controller_spec.rb' - - 'spec/controllers/api/variants_controller_spec.rb' + - 'spec/controllers/api/v0/order_cycles_controller_spec.rb' + - 'spec/controllers/api/v0/orders_controller_spec.rb' + - 'spec/controllers/api/v0/products_controller_spec.rb' + - 'spec/controllers/api/v0/shipments_controller_spec.rb' + - 'spec/controllers/api/v0/variants_controller_spec.rb' - 'spec/controllers/checkout_controller_spec.rb' - 'spec/controllers/enterprises_controller_spec.rb' - 'spec/controllers/spree/admin/orders/invoices_spec.rb' + - 'spec/controllers/spree/admin/orders/payments/payments_controller_spec.rb' - 'spec/controllers/spree/admin/overview_controller_spec.rb' - 'spec/controllers/spree/admin/payment_methods_controller_spec.rb' - 'spec/controllers/spree/credit_cards_controller_spec.rb' + - 'spec/controllers/spree/orders_controller_spec.rb' - 'spec/factories.rb' - 'spec/factories/order_factory.rb' - 'spec/factories/shipment_factory.rb' @@ -635,6 +464,7 @@ Rails/SkipsModelValidations: - 'spec/features/admin/order_cycles/complex_editing_spec.rb' - 'spec/features/admin/order_cycles/simple_spec.rb' - 'spec/features/admin/order_spec.rb' + - 'spec/features/admin/payments_spec.rb' - 'spec/features/admin/reports_spec.rb' - 'spec/features/consumer/caching/shops_caching_spec.rb' - 'spec/features/consumer/shopping/checkout_spec.rb' @@ -651,17 +481,19 @@ Rails/SkipsModelValidations: - 'spec/lib/open_food_network/scope_variant_to_hub_spec.rb' - 'spec/lib/stripe/credit_card_cloner_spec.rb' - 'spec/lib/tasks/data/remove_transient_data_spec.rb' + - 'spec/migrations/migrate_enterprise_fee_tax_amounts_spec.rb' - 'spec/models/concerns/variant_stock_spec.rb' - 'spec/models/enterprise_relationship_spec.rb' - 'spec/models/exchange_spec.rb' - 'spec/models/spree/adjustment_spec.rb' - 'spec/models/spree/asset_spec.rb' - 'spec/models/spree/line_item_spec.rb' + - 'spec/models/spree/order/tax_spec.rb' - 'spec/models/spree/order_inventory_spec.rb' - 'spec/models/spree/order_spec.rb' - 'spec/models/spree/tax_category_spec.rb' + - 'spec/models/spree/tax_rate_spec.rb' - 'spec/models/spree/variant_spec.rb' - - 'spec/models/tag_rule/discount_order_spec.rb' - 'spec/queries/customers_with_balance_spec.rb' - 'spec/queries/outstanding_balance_spec.rb' - 'spec/serializers/api/admin/subscription_line_item_serializer_spec.rb' @@ -677,7 +509,7 @@ Rails/SkipsModelValidations: - 'spec/support/request/shop_workflow.rb' - 'spec/views/spree/shared/_order_details.html.haml_spec.rb' -# Offense count: 9 +# Offense count: 11 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. # SupportedStyles: strict, flexible @@ -687,6 +519,7 @@ Rails/TimeZone: - 'spec/controllers/spree/credit_cards_controller_spec.rb' - 'spec/features/admin/order_cycles/complex_creating_specific_time_spec.rb' - 'spec/features/admin/order_cycles/simple_spec.rb' + - 'spec/models/spree/tax_rate_spec.rb' - 'spec/services/customer_order_cancellation_spec.rb' # Offense count: 5 @@ -709,46 +542,29 @@ Rails/UnknownEnv: - 'app/models/spree/app_configuration.rb' - 'lib/spree/core/controller_helpers/ssl.rb' -# Offense count: 15 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle. -# SupportedStyles: separated, grouped -Style/AccessorGrouping: - Exclude: - - 'app/controllers/admin/resource_controller.rb' - - 'app/models/customer.rb' - - 'app/models/product_import/spreadsheet_entry.rb' - - 'app/models/spree/line_item.rb' - - 'app/services/action_callbacks.rb' - - 'app/services/cart_service.rb' - - 'lib/discourse/single_sign_on.rb' - -# Offense count: 2 +# Offense count: 1 # Cop supports --auto-correct. # Configuration parameters: AllowOnConstant. Style/CaseEquality: Exclude: - - 'app/helpers/angular_form_helper.rb' - 'spec/models/spree/payment_spec.rb' -# Offense count: 5 +# Offense count: 4 # Cop supports --auto-correct. Style/CaseLikeIf: Exclude: - 'app/controllers/admin/order_cycles_controller.rb' - - 'app/controllers/spree/orders_controller.rb' - 'app/models/calculator/weight.rb' - 'app/models/spree/payment/processing.rb' - 'lib/active_merchant/billing/gateways/stripe_payment_intents.rb' -# Offense count: 26 +# Offense count: 25 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. # SupportedStyles: nested, compact Style/ClassAndModuleChildren: Exclude: - 'app/models/calculator/flat_percent_per_item.rb' - - 'app/models/tag_rule/discount_order.rb' - 'app/models/tag_rule/filter_order_cycles.rb' - 'app/models/tag_rule/filter_payment_methods.rb' - 'app/models/tag_rule/filter_shipping_methods.rb' @@ -772,46 +588,18 @@ Style/ClassAndModuleChildren: - 'spec/controllers/spree/admin/base_controller_spec.rb' - 'spec/models/spree/payment_method_spec.rb' -# Offense count: 5 -# Cop supports --auto-correct. -# Configuration parameters: IgnoredMethods. -# IgnoredMethods: ==, equal?, eql? -Style/ClassEqualityComparison: - Exclude: - - 'app/controllers/spree/admin/payments_controller.rb' - - 'app/models/tag_rule/discount_order.rb' - - 'spec/lib/open_food_network/group_buy_report_spec.rb' - -# Offense count: 3 +# Offense count: 1 Style/ClassVars: Exclude: - - 'lib/open_food_network/rack_request_blocker.rb' - 'lib/spree/core/delegate_belongs_to.rb' -# Offense count: 1 -# Cop supports --auto-correct. -Style/ExpandPathArguments: - Exclude: - - 'config.ru' - -# Offense count: 8 -# Cop supports --auto-correct. -Style/ExplicitBlockArgument: - Exclude: - - 'app/helpers/groups_helper.rb' - - 'app/services/cache_service.rb' - - 'app/services/current_order_locker.rb' - - 'spec/support/embedded_pages_helper.rb' - - 'spec/support/performance_helper.rb' - - 'spec/support/request/shop_workflow.rb' - # Offense count: 2 # Configuration parameters: MaxUnannotatedPlaceholdersAllowed, IgnoredMethods. # SupportedStyles: annotated, template, unannotated Style/FormatStringToken: EnforcedStyle: unannotated -# Offense count: 354 +# Offense count: 336 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. # SupportedStyles: always, always_true, never @@ -843,21 +631,7 @@ Style/FrozenStringLiteralComment: - 'app/controllers/admin/subscriptions_controller.rb' - 'app/controllers/admin/tag_rules_controller.rb' - 'app/controllers/admin/variant_overrides_controller.rb' - - 'app/controllers/api/base_controller.rb' - - 'app/controllers/api/customers_controller.rb' - - 'app/controllers/api/enterprise_fees_controller.rb' - - 'app/controllers/api/enterprises_controller.rb' - - 'app/controllers/api/logos_controller.rb' - - 'app/controllers/api/order_cycles_controller.rb' - - 'app/controllers/api/orders_controller.rb' - - 'app/controllers/api/product_images_controller.rb' - - 'app/controllers/api/products_controller.rb' - - 'app/controllers/api/promo_images_controller.rb' - - 'app/controllers/api/shipments_controller.rb' - - 'app/controllers/api/statuses_controller.rb' - - 'app/controllers/api/taxonomies_controller.rb' - - 'app/controllers/api/taxons_controller.rb' - - 'app/controllers/api/variants_controller.rb' + - 'app/controllers/api/v0/taxons_controller.rb' - 'app/controllers/cart_controller.rb' - 'app/controllers/discourse_sso_controller.rb' - 'app/controllers/enterprises_controller.rb' @@ -933,6 +707,7 @@ Style/FrozenStringLiteralComment: - 'app/helpers/spree/admin/taxons_helper.rb' - 'app/helpers/spree/admin/zones_helper.rb' - 'app/helpers/spree/orders_helper.rb' + - 'app/helpers/spree/payment_methods_helper.rb' - 'app/helpers/spree/reports_helper.rb' - 'app/helpers/spree_currency_helper.rb' - 'app/jobs/subscription_confirm_job.rb' @@ -946,7 +721,6 @@ Style/FrozenStringLiteralComment: - 'app/models/column_preference.rb' - 'app/models/concerns/address_display.rb' - 'app/models/concerns/adjustment_scopes.rb' - - 'app/models/concerns/line_item_based_adjustment_handling.rb' - 'app/models/concerns/order_shipment.rb' - 'app/models/concerns/product_stock.rb' - 'app/models/concerns/stock_settings_override_validation.rb' @@ -991,7 +765,6 @@ Style/FrozenStringLiteralComment: - 'app/models/subscription.rb' - 'app/models/subscription_line_item.rb' - 'app/models/tag_rule.rb' - - 'app/models/tag_rule/discount_order.rb' - 'app/models/tag_rule/filter_order_cycles.rb' - 'app/models/tag_rule/filter_payment_methods.rb' - 'app/models/tag_rule/filter_products.rb' @@ -1035,6 +808,7 @@ Style/FrozenStringLiteralComment: - 'app/services/cart_service.rb' - 'app/services/create_order_cycle.rb' - 'app/services/current_order_locker.rb' + - 'app/services/default_country.rb' - 'app/services/default_shipping_category.rb' - 'app/services/default_stock_location.rb' - 'app/services/embedded_page_service.rb' @@ -1056,6 +830,7 @@ Style/FrozenStringLiteralComment: - 'app/services/products_renderer.rb' - 'app/services/search_orders.rb' - 'app/services/tax_rate_finder.rb' + - 'app/services/terms_of_service.rb' - 'app/services/upload_sanitizer.rb' - 'app/services/variant_deleter.rb' - 'app/services/variant_units/variant_and_line_item_naming.rb' @@ -1088,7 +863,6 @@ Style/FrozenStringLiteralComment: - 'engines/order_management/app/services/reports/renderers/base.rb' - 'engines/order_management/app/services/reports/report_data/base.rb' - 'engines/web/app/controllers/web/angular_templates_controller.rb' - - 'engines/web/app/controllers/web/api/v0/cookies_consent_controller.rb' - 'engines/web/app/controllers/web/application_controller.rb' - 'engines/web/app/helpers/web/cookies_policy_helper.rb' - 'engines/web/lib/web/cookies_consent.rb' @@ -1108,8 +882,6 @@ Style/FrozenStringLiteralComment: - 'lib/open_food_network/lettuce_share_report.rb' - 'lib/open_food_network/order_and_distributor_report.rb' - 'lib/open_food_network/order_cycle_form_applicator.rb' - - 'lib/open_food_network/order_cycle_management_report.rb' - - 'lib/open_food_network/order_cycle_permissions.rb' - 'lib/open_food_network/order_grouper.rb' - 'lib/open_food_network/orders_and_fulfillments_report.rb' - 'lib/open_food_network/orders_and_fulfillments_report/customer_totals_report.rb' @@ -1123,7 +895,6 @@ Style/FrozenStringLiteralComment: - 'lib/open_food_network/products_and_inventory_report.rb' - 'lib/open_food_network/products_and_inventory_report_base.rb' - 'lib/open_food_network/property_merge.rb' - - 'lib/open_food_network/rack_request_blocker.rb' - 'lib/open_food_network/referer_parser.rb' - 'lib/open_food_network/reports/line_items.rb' - 'lib/open_food_network/reports/list.rb' @@ -1161,9 +932,12 @@ Style/FrozenStringLiteralComment: - 'lib/tasks/sample_data/user_factory.rb' - 'lib/tasks/specs.rake' - 'lib/tasks/users.rake' + - 'spec/components/distributor_title_component_spec.rb' + - 'spec/components/example_component_spec.rb' + - 'spec/components/stories/distributor_title_component_stories.rb' + - 'spec/components/stories/example_component_stories.rb' - 'spec/features/consumer/shopping/unit_price_spec.rb' - 'spec/helpers/terms_and_conditions_helper_spec.rb' - - 'spec/initializers/feature_toggles_spec.rb' - 'spec/lib/open_food_network/reports/line_items_spec.rb' - 'spec/models/concerns/balance_spec.rb' - 'spec/services/order_data_masker_spec.rb' @@ -1185,56 +959,31 @@ Style/GuardClause: - 'app/controllers/admin/enterprises_controller.rb' - 'app/controllers/admin/order_cycles_controller.rb' - 'app/controllers/admin/product_import_controller.rb' - - 'app/controllers/api/shipments_controller.rb' + - 'app/controllers/api/v0/shipments_controller.rb' - 'app/controllers/application_controller.rb' - 'app/controllers/home_controller.rb' - 'app/controllers/spree/orders_controller.rb' - 'app/models/enterprise.rb' - 'app/models/enterprise_group.rb' - 'app/models/producer_property.rb' + - 'app/models/product_import/entry_processor.rb' + - 'app/models/spree/order.rb' - 'app/models/spree/preferences/preferable_class_methods.rb' - 'app/services/order_syncer.rb' - 'app/services/variant_units/variant_and_line_item_naming.rb' + - 'engines/order_management/app/services/order_management/order/updater.rb' - 'lib/discourse/single_sign_on.rb' - 'lib/open_food_network/order_cycle_form_applicator.rb' - - 'lib/open_food_network/rack_request_blocker.rb' - 'lib/spree/core/controller_helpers/respond_with.rb' - 'spec/support/request/distribution_helper.rb' - 'spec/support/request/shop_workflow.rb' -# Offense count: 10 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle. -# SupportedStyles: braces, no_braces -Style/HashAsLastArrayItem: - Exclude: - - 'app/controllers/admin/enterprises_controller.rb' - - 'app/controllers/admin/subscriptions_controller.rb' - - 'app/services/exchange_products_renderer.rb' - - 'app/services/permitted_attributes/checkout.rb' - - 'app/services/permitted_attributes/order_cycle.rb' - - 'app/services/permitted_attributes/product.rb' - - 'lib/open_food_network/orders_and_fulfillments_report/distributor_totals_by_supplier_report.rb' - - 'lib/open_food_network/xero_invoices_report.rb' - # Offense count: 1 # Configuration parameters: MinBranchesCount. Style/HashLikeCase: Exclude: - 'app/models/enterprise.rb' -# Offense count: 9 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, UseHashRocketsWithSymbolValues, PreferHashRocketsForNonAlnumEndingSymbols. -# SupportedStyles: ruby19, hash_rockets, no_mixed_keys, ruby19_no_mixed_keys -Style/HashSyntax: - Exclude: - - 'spec/features/admin/order_cycles/simple_spec.rb' - - 'spec/features/consumer/account/cards_spec.rb' - - 'spec/features/consumer/account/payments_spec.rb' - - 'spec/features/consumer/account/settings_spec.rb' - - 'spec/features/consumer/account_spec.rb' - # Offense count: 3 Style/MissingRespondToMissing: Exclude: @@ -1248,7 +997,22 @@ Style/MixinUsage: - 'lib/open_food_network/orders_and_fulfillments_report.rb' - 'spec/lib/open_food_network/packing_report_spec.rb' -# Offense count: 41 +# Offense count: 22 +# Cop supports --auto-correct. +Style/NestedModifier: + Exclude: + - 'spec/controllers/admin/subscriptions_controller_spec.rb' + - 'spec/controllers/line_items_controller_spec.rb' + - 'spec/controllers/spree/admin/orders_controller_spec.rb' + - 'spec/controllers/spree/orders_controller_spec.rb' + - 'spec/factories/order_factory.rb' + - 'spec/features/admin/payments_stripe_spec.rb' + - 'spec/features/admin/reports_spec.rb' + - 'spec/jobs/subscription_placement_job_spec.rb' + - 'spec/models/proxy_order_spec.rb' + - 'spec/models/spree/line_item_spec.rb' + +# Offense count: 34 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, IgnoredMethods. # SupportedStyles: predicate, comparison @@ -1265,16 +1029,13 @@ Style/NumericPredicate: - 'app/models/spree/order.rb' - 'app/models/spree/order_contents.rb' - 'app/models/spree/order_inventory.rb' - - 'app/models/spree/preferences/preferable.rb' - 'app/models/spree/user.rb' - 'app/models/variant_override.rb' - 'app/services/cart_service.rb' - 'lib/open_food_network/customers_report.rb' - 'lib/open_food_network/enterprise_fee_calculator.rb' - 'lib/open_food_network/products_and_inventory_report_base.rb' - - 'lib/open_food_network/rack_request_blocker.rb' - 'lib/open_food_network/sales_tax_report.rb' - - 'lib/open_food_network/xero_invoices_report.rb' - 'lib/tasks/sample_data.rake' # Offense count: 26 @@ -1287,9 +1048,9 @@ Style/OptionalBooleanParameter: - 'app/mailers/spree/shipment_mailer.rb' - 'app/models/enterprise_relationship.rb' - 'app/models/product_import/entry_processor.rb' + - 'app/models/spree/order_contents.rb' - 'app/models/spree/preferences/file_configuration.rb' - 'app/models/spree/shipment.rb' - - 'app/services/cart_service.rb' - 'engines/order_management/app/services/order_management/reports/bulk_coop/bulk_coop_report.rb' - 'engines/order_management/app/services/order_management/stock/estimator.rb' - 'lib/open_food_network/customers_report.rb' @@ -1306,69 +1067,15 @@ Style/OptionalBooleanParameter: - 'lib/spree/core/delegate_belongs_to.rb' - 'spec/support/request/web_helper.rb' -# Offense count: 3 -# Cop supports --auto-correct. -Style/RedundantAssignment: - Exclude: - - 'app/models/spree/payment.rb' - - 'app/models/spree/taxon.rb' - - 'lib/open_food_network/order_grouper.rb' - -# Offense count: 3 -# Cop supports --auto-correct. -Style/RedundantBegin: - Exclude: - - 'lib/open_food_network/enterprise_injection_data.rb' - - 'lib/open_food_network/order_cycle_permissions.rb' - -# Offense count: 2 -# Cop supports --auto-correct. -Style/RedundantFileExtensionInRequire: - Exclude: - - 'engines/catalog/spec/spec_helper.rb' - - 'engines/dfc_provider/spec/spec_helper.rb' - # Offense count: 1 # Cop supports --auto-correct. -Style/RedundantInterpolation: +# Configuration parameters: EnforcedStyle. +# SupportedStyles: short, verbose +Style/PreferredHashMethods: Exclude: - - 'spec/initializers/feature_toggles_spec.rb' + - 'app/controllers/api/v0/shipments_controller.rb' -# Offense count: 2 -# Cop supports --auto-correct. -Style/RedundantRegexpCharacterClass: - Exclude: - - 'app/models/spree/order.rb' - - 'lib/stripe/authorize_response_patcher.rb' - -# Offense count: 11 -# Cop supports --auto-correct. -Style/RedundantRegexpEscape: - Exclude: - - 'app/models/spree/order.rb' - - 'engines/web/config/routes.rb' - - 'lib/spree/localized_number.rb' - - 'lib/stripe/authorize_response_patcher.rb' - -# Offense count: 1 -# Cop supports --auto-correct. -# Configuration parameters: AllowMultipleReturnValues. -Style/RedundantReturn: - Exclude: - - 'spec/support/features/datepicker_helper.rb' - -# Offense count: 6 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, AllowInnerSlashes. -# SupportedStyles: slashes, percent_r, mixed -Style/RegexpLiteral: - Exclude: - - 'spec/features/consumer/account/cards_spec.rb' - - 'spec/features/consumer/account/payments_spec.rb' - - 'spec/features/consumer/account/settings_spec.rb' - - 'spec/features/consumer/account_spec.rb' - -# Offense count: 240 +# Offense count: 236 Style/Send: Exclude: - 'engines/order_management/spec/services/order_management/reports/bulk_coop/bulk_coop_report_spec.rb' @@ -1399,7 +1106,6 @@ Style/Send: - 'spec/models/spree/payment_spec.rb' - 'spec/models/spree/return_authorization_spec.rb' - 'spec/models/spree/tax_rate_spec.rb' - - 'spec/models/tag_rule/discount_order_spec.rb' - 'spec/models/tag_rule/filter_order_cycles_spec.rb' - 'spec/models/tag_rule/filter_payment_methods_spec.rb' - 'spec/models/tag_rule/filter_products_spec.rb' @@ -1417,22 +1123,17 @@ Style/SingleArgumentDig: - 'app/services/checkout/form_data_adapter.rb' - 'lib/active_merchant/billing/gateways/stripe_payment_intents.rb' -# Offense count: 10 +# Offense count: 5 # Cop supports --auto-correct. -# Configuration parameters: AllowModifier. -Style/SoleNestedConditional: +Style/SlicingWithRange: Exclude: - - 'Rakefile' - - 'app/controllers/checkout_controller.rb' - - 'app/models/product_import/spreadsheet_entry.rb' - - 'app/models/spree/address.rb' - - 'app/models/spree/preferences/store.rb' - - 'app/services/order_syncer.rb' - - 'app/services/order_workflow.rb' - - 'lib/spree/core/controller_helpers/order.rb' - - 'spec/support/matchers/select2_matchers.rb' + - 'app/helpers/spree/admin/navigation_helper.rb' + - 'app/services/embedded_page_service.rb' + - 'engines/order_management/app/services/order_management/subscriptions/validator.rb' + - 'lib/discourse/single_sign_on.rb' + - 'spec/lib/open_food_network/order_grouper_spec.rb' -# Offense count: 45 +# Offense count: 43 # Cop supports --auto-correct. Style/StringConcatenation: Exclude: @@ -1443,9 +1144,7 @@ Style/StringConcatenation: - 'app/mailers/spree/user_mailer.rb' - 'app/models/enterprise.rb' - 'app/models/spree/credit_card.rb' - - 'app/models/spree/line_item.rb' - 'app/models/spree/payment_method.rb' - - 'app/models/spree/tax_rate.rb' - 'app/serializers/api/cached_enterprise_serializer.rb' - 'app/serializers/api/enterprise_shopfront_list_serializer.rb' - 'app/services/embedded_page_service.rb' @@ -1468,31 +1167,3 @@ Style/StringConcatenation: - 'spec/services/embedded_page_service_spec.rb' - 'spec/support/api_helper.rb' - 'spec/support/features/datepicker_helper.rb' - -# Offense count: 1 -# Cop supports --auto-correct. -Style/StructInheritance: - Exclude: - - 'lib/open_food_network/enterprise_fee_applicator.rb' - -# Offense count: 2 -# Cop supports --auto-correct. -# Configuration parameters: AllowMethodsWithArguments, IgnoredMethods. -# IgnoredMethods: respond_to, define_method -Style/SymbolProc: - Exclude: - - 'app/models/spree/preferences/preferable.rb' - -# Offense count: 19 -# Cop supports --auto-correct. -Style/WhileUntilModifier: - Exclude: - - 'spec/controllers/admin/subscriptions_controller_spec.rb' - - 'spec/controllers/line_items_controller_spec.rb' - - 'spec/controllers/spree/admin/orders_controller_spec.rb' - - 'spec/controllers/spree/orders_controller_spec.rb' - - 'spec/factories/order_factory.rb' - - 'spec/features/admin/payments_stripe_spec.rb' - - 'spec/jobs/subscription_placement_job_spec.rb' - - 'spec/models/proxy_order_spec.rb' - - 'spec/models/spree/line_item_spec.rb'