From e4cf6421bd06349e4a6481dd5069b43c0dbcfe7f Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed, 16 Jun 2021 05:18:50 +0000 Subject: [PATCH 1/3] Bump bigdecimal from 1.4.2 to 3.0.2 Bumps [bigdecimal](https://github.com/ruby/bigdecimal) from 1.4.2 to 3.0.2. - [Release notes](https://github.com/ruby/bigdecimal/releases) - [Changelog](https://github.com/ruby/bigdecimal/blob/v3.0.2/CHANGES.md) - [Commits](https://github.com/ruby/bigdecimal/compare/v1.4.2...v3.0.2) --- updated-dependencies: - dependency-name: bigdecimal dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] --- Gemfile | 2 +- Gemfile.lock | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Gemfile b/Gemfile index 773c50d1d2..da0dfa0159 100644 --- a/Gemfile +++ b/Gemfile @@ -66,7 +66,7 @@ gem "active_model_serializers", "0.8.4" gem 'activerecord-session_store' gem 'acts-as-taggable-on', '~> 8.0' gem 'angularjs-file-upload-rails', '~> 2.4.1' -gem 'bigdecimal', '1.4.2' # There are issues using later versions of bigdecimal +gem 'bigdecimal', '3.0.2' # There are issues using later versions of bigdecimal gem 'bootsnap', require: false gem 'custom_error_message', github: 'jeremydurham/custom-err-msg' gem 'dalli' diff --git a/Gemfile.lock b/Gemfile.lock index 8b7f2de807..3b55caafb7 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -157,7 +157,7 @@ GEM json (~> 1.4) nokogiri (~> 1) bcrypt (3.1.16) - bigdecimal (1.4.2) + bigdecimal (3.0.2) bindex (0.8.1) bootsnap (1.7.5) msgpack (~> 1.0) @@ -687,7 +687,7 @@ DEPENDENCIES awesome_nested_set awesome_print aws-sdk (= 1.67.0) - bigdecimal (= 1.4.2) + bigdecimal (= 3.0.2) bootsnap bugsnag bullet From a7d873356dbc2e78de62ea7089e6b6e5a535f0d3 Mon Sep 17 00:00:00 2001 From: Matt-Yorkley <9029026+Matt-Yorkley@users.noreply.github.com> Date: Thu, 17 Jun 2021 15:51:06 +0100 Subject: [PATCH 2/3] Fix shady use of BigDecimal --- .../spec/services/order_management/stock/estimator_spec.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/engines/order_management/spec/services/order_management/stock/estimator_spec.rb b/engines/order_management/spec/services/order_management/stock/estimator_spec.rb index e71d452798..042b4958d2 100644 --- a/engines/order_management/spec/services/order_management/stock/estimator_spec.rb +++ b/engines/order_management/spec/services/order_management/stock/estimator_spec.rb @@ -76,7 +76,7 @@ module OrderManagement allow(subject).to receive(:shipping_methods).and_return(shipping_methods) - expected_costs = %w[3.00 4.00 5.00].map(&BigDecimal.method(:new)) + expected_costs = [3.00, 4.00, 5.00] expect(subject.shipping_rates(package).map(&:cost)).to eq expected_costs end From e4e84b0a860ff5f595955901770d5a452120fc63 Mon Sep 17 00:00:00 2001 From: Matt-Yorkley <9029026+Matt-Yorkley@users.noreply.github.com> Date: Thu, 17 Jun 2021 16:05:12 +0100 Subject: [PATCH 3/3] Remove old warning on BigDecimal gem --- Gemfile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Gemfile b/Gemfile index da0dfa0159..fd082ff64d 100644 --- a/Gemfile +++ b/Gemfile @@ -66,7 +66,7 @@ gem "active_model_serializers", "0.8.4" gem 'activerecord-session_store' gem 'acts-as-taggable-on', '~> 8.0' gem 'angularjs-file-upload-rails', '~> 2.4.1' -gem 'bigdecimal', '3.0.2' # There are issues using later versions of bigdecimal +gem 'bigdecimal', '3.0.2' gem 'bootsnap', require: false gem 'custom_error_message', github: 'jeremydurham/custom-err-msg' gem 'dalli'