From 4b1d7d8a415aef8e2542892d6749f1e4a6b6c741 Mon Sep 17 00:00:00 2001 From: Maikel Linke Date: Wed, 2 Oct 2024 16:18:38 +1000 Subject: [PATCH] Remove dead permission to access StockLocation We don't have any UI to edit stock locations. So this ability is unused. --- app/models/spree/ability.rb | 1 - spec/models/spree/ability_spec.rb | 7 ------- 2 files changed, 8 deletions(-) diff --git a/app/models/spree/ability.rb b/app/models/spree/ability.rb index 34328d5389..3233e58c6d 100644 --- a/app/models/spree/ability.rb +++ b/app/models/spree/ability.rb @@ -35,7 +35,6 @@ module Spree can [:read, :update, :destroy], Spree::User, id: user.id can [:index, :read], State can [:index, :read], StockItem - can [:index, :read], StockLocation can [:index, :read], StockMovement can [:index, :read], Taxon can [:index, :read], Variant diff --git a/spec/models/spree/ability_spec.rb b/spec/models/spree/ability_spec.rb index c2b0ee3a50..aea98c3530 100644 --- a/spec/models/spree/ability_spec.rb +++ b/spec/models/spree/ability_spec.rb @@ -125,13 +125,6 @@ RSpec.describe Spree::Ability do end end - context 'for StockLocation' do - let(:resource) { Spree::StockLocation.new } - context 'requested by any user' do - it_should_behave_like 'read only' - end - end - context 'for StockMovement' do let(:resource) { Spree::StockMovement.new } context 'requested by any user' do