From 47d51ca525923b82dc8e1f229a76c7f3d3de1f50 Mon Sep 17 00:00:00 2001
From: Kristina Lim <kristinalim.ph@gmail.com>
Date: Fri, 30 Nov 2018 00:13:52 +0800
Subject: [PATCH] Prefer guard clause in updateCountOnHand for VOs

---
 .../controllers/variant_overrides_controller.js.coffee      | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/app/assets/javascripts/admin/variant_overrides/controllers/variant_overrides_controller.js.coffee b/app/assets/javascripts/admin/variant_overrides/controllers/variant_overrides_controller.js.coffee
index 2727472b5a..933566a191 100644
--- a/app/assets/javascripts/admin/variant_overrides/controllers/variant_overrides_controller.js.coffee
+++ b/app/assets/javascripts/admin/variant_overrides/controllers/variant_overrides_controller.js.coffee
@@ -131,9 +131,9 @@ angular.module("admin.variantOverrides").controller "AdminVariantOverridesCtrl",
     variantOverride = $scope.variantOverrides[hubId][variant.id]
 
     suggested = $scope.countOnHandSuggestion(variant, hubId)
-    unless suggested == variantOverride.count_on_hand
-      variantOverride.count_on_hand = suggested
-      DirtyVariantOverrides.set hubId, variant.id, variantOverride.id, 'count_on_hand', suggested
+    return if suggested == variantOverride.count_on_hand
+    variantOverride.count_on_hand = suggested
+    DirtyVariantOverrides.set hubId, variant.id, variantOverride.id, 'count_on_hand', suggested
 
   # Suggest producer count_on_hand if variant has limited stock and variant override forces limited
   # stock. Otherwise, clear whatever value is set.