From 4785f3eacc69a6c6158d13dde395c011ad77dae2 Mon Sep 17 00:00:00 2001 From: Rob Harrington Date: Thu, 14 Sep 2017 10:22:24 +1000 Subject: [PATCH] Use lowercased cc_type in CreditCard service --- .../darkswarm/services/credit_card.js.coffee | 2 +- .../services/credit_card_spec.js.coffee | 31 +++++++++++++++++++ 2 files changed, 32 insertions(+), 1 deletion(-) create mode 100644 spec/javascripts/unit/darkswarm/services/credit_card_spec.js.coffee diff --git a/app/assets/javascripts/darkswarm/services/credit_card.js.coffee b/app/assets/javascripts/darkswarm/services/credit_card.js.coffee index 5f7fa5c0ce..28c2cde5f3 100644 --- a/app/assets/javascripts/darkswarm/services/credit_card.js.coffee +++ b/app/assets/javascripts/darkswarm/services/credit_card.js.coffee @@ -31,7 +31,7 @@ Darkswarm.factory 'CreditCard', ($injector, $rootScope, CreditCards, StripeEleme "exp_year": @secrets.card.exp_year, "last4": @secrets.card.last4, "token": @secrets.token, - "cc_type": @secrets.card.brand} + "cc_type": @secrets.cc_type} show: => @visible = true diff --git a/spec/javascripts/unit/darkswarm/services/credit_card_spec.js.coffee b/spec/javascripts/unit/darkswarm/services/credit_card_spec.js.coffee new file mode 100644 index 0000000000..f6b6993859 --- /dev/null +++ b/spec/javascripts/unit/darkswarm/services/credit_card_spec.js.coffee @@ -0,0 +1,31 @@ +describe 'CreditCard service', -> + CreditCard = null + + beforeEach -> + module 'Darkswarm' + module ($provide)-> + $provide.value "savedCreditCards", [] + $provide.value "railsFlash", null + null + + inject (_CreditCard_)-> + CreditCard = _CreditCard_ + + describe "process_params", -> + beforeEach -> + CreditCard.secrets = + card: + exp_month: "12" + exp_year: "2030" + last4: "1234" + cc_type: 'mastercard' + token: "token123" + + it "uses cc_type, rather than fetching the brand from the card", -> + # This is important for processing the card with activemerchant + process_params = CreditCard.process_params() + expect(process_params['exp_month']).toEqual "12" + expect(process_params['exp_year']).toEqual "2030" + expect(process_params['last4']).toEqual "1234" + expect(process_params['token']).toEqual "token123" + expect(process_params['cc_type']).toEqual "mastercard"