From 4634c2d965ca44817f4c563545e17dddc106fe16 Mon Sep 17 00:00:00 2001 From: Mohamed ABDELLANI Date: Thu, 12 Oct 2023 16:02:32 +0100 Subject: [PATCH] add unit_price_price_and_unit to line_item serializer * unit_price_price_and_unit refers UnitPrice which refers to other attributes that belong to variant and product. Instead of collecting all the attributes that were using indirectly by the method and adding them to the serializers I perefered to serialize the result of the method call. --- app/models/invoice/data_presenter/line_item.rb | 2 +- app/serializers/invoice/line_item_serializer.rb | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/app/models/invoice/data_presenter/line_item.rb b/app/models/invoice/data_presenter/line_item.rb index 0e091a0655..40a0353d4b 100644 --- a/app/models/invoice/data_presenter/line_item.rb +++ b/app/models/invoice/data_presenter/line_item.rb @@ -4,7 +4,7 @@ class Invoice class DataPresenter class LineItem < Invoice::DataPresenter::Base attributes :added_tax, :currency, :included_tax, :price_with_adjustments, :quantity, - :variant_id + :variant_id, :unit_price_price_and_unit attributes_with_presenter :variant array_attribute :tax_rates, class_name: 'TaxRate' invoice_generation_attributes :added_tax, :included_tax, :price_with_adjustments, diff --git a/app/serializers/invoice/line_item_serializer.rb b/app/serializers/invoice/line_item_serializer.rb index fe037b4d16..3fba186bf3 100644 --- a/app/serializers/invoice/line_item_serializer.rb +++ b/app/serializers/invoice/line_item_serializer.rb @@ -3,7 +3,7 @@ class Invoice class LineItemSerializer < ActiveModel::Serializer attributes :id, :added_tax, :currency, :included_tax, :price_with_adjustments, :quantity, - :variant_id + :variant_id, :unit_price_price_and_unit has_one :variant, serializer: Invoice::VariantSerializer has_many :tax_rates, serializer: Invoice::TaxRateSerializer end