raggedstaff/openfoodnetwork
1
0
Fork 0
mirror of https://github.com/openfoodfoundation/openfoodnetwork synced 2026-03-13 04:00:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #2539 from luisramos0/delete_dead_cart

Browse Source 
removed Cart route, controller, model and specs: dead code
This commit is contained in:
Maikel
2018-08-22 17:35:58 +10:00
committed by GitHub
parent e0d13010bb 91e57cb893
commit 4417a8f156
15 changed files with 8 additions and 340 deletions
Download Patch File Download Diff File Expand all files Collapse all files

86
spec/controllers/cart_controller_spec.rb
View File

@@ -1,86 +0,0 @@
require 'spec_helper'
require 'spree/api/testing_support/helpers'
module OpenFoodNetwork
describe CartController, type: :controller do
render_views
let(:user) { FactoryBot.create(:user) }
let(:product1) { FactoryBot.create(:product) }
let(:cart) { Cart.create(user: user) }
let(:distributor) { FactoryBot.create(:distributor_enterprise) }
before do
end
context "as a normal user" do
context 'with an existing cart' do
it "retrieves an empty cart" do
get :show, {id: cart, :format => :json }
json_response = JSON.parse(response.body)
json_response['id'].should == cart.id
json_response['orders'].size.should == 0
end
context 'with an empty order' do
let(:order) { FactoryBot.create(:order, distributor: distributor) }
before(:each) do
cart.orders << order
cart.save!
end
it "retrieves a cart with a single order and line item" do
get :show, {id: cart, :format => :json }
json_response = JSON.parse(response.body)
json_response['orders'].size.should == 1
json_response['orders'].first['distributor'].should == order.distributor.name
json_response['orders'].first['line_items'].size.should == 0
end
end
context 'an order with line items' do
let(:product) { FactoryBot.create(:product, distributors: [ distributor ]) }
let(:order) { FactoryBot.create(:order, { distributor: distributor } ) }
let(:line_item) { FactoryBot.create(:line_item, { variant: product.master }) }
before(:each) do
order.line_items << line_item
order.save
cart.orders << order
cart.save!
end
it "retrieves a cart with a single order and line item" do
get :show, {id: cart, :format => :json }
json_response = JSON.parse(response.body)
json_response['orders'].size.should == 1
json_response['orders'].first['distributor'].should == order.distributor.name
json_response['orders'].first['line_items'].first["name"].should == product.name
json_response['orders'].first['line_items'].first["quantity"].should == line_item.quantity
end
end
context 'adding a variant' do
it 'should add variant to new order and return the order' do
product1.distributors << distributor
product1.save
variant = product1.variants.first
put :add_variant, { cart_id: cart, variant_id: variant.id, quantity: (variant.on_hand-1), distributor_id: distributor, order_cycle_id: nil, max_quantity: nil }
cart.orders.size.should == 1
cart.orders.first.line_items.size.should == 1
cart.orders.first.line_items.first.product.should == product1
end
end
end
end
end
end

131
spec/models/cart_spec.rb
View File

@@ -1,131 +0,0 @@
require 'spec_helper'
# TODO this seems to be redundant
describe Cart do
describe "associations" do
it { should have_many(:orders) }
end
describe 'when adding a product' do
let(:cart) { Cart.create(user: user) }
let(:distributor) { FactoryBot.create(:distributor_enterprise) }
let(:other_distributor) { FactoryBot.create(:distributor_enterprise) }
let(:currency) { "AUD" }
let(:product) { FactoryBot.create(:product, :distributors => [distributor]) }
let(:product_with_order_cycle) { create(:product) }
let(:order_cycle) { create(:simple_order_cycle, distributors: [distributor, other_distributor], variants: [product_with_order_cycle.master]) }
describe 'to an empty cart' do
it 'should create an order for the product being added, and associate the product to the selected distribution' do
subject.add_variant product.master.id, 3, distributor, nil, currency
subject.orders.size.should == 1
order = subject.orders.first.reload
order.currency.should == currency
order.distributor.should == product.distributors.first
order.order_cycle.should be_nil
order.line_items.first.product.should == product
end
it 'should create an order for the product being added, and associate the order with an order cycle and distributor' do
subject.add_variant product_with_order_cycle.master.id, 3, distributor, order_cycle, currency
subject.orders.size.should == 1
order = subject.orders.first.reload
order.currency.should == currency
order.distributor.should == distributor
order.order_cycle.should == order_cycle
order.line_items.first.product.should == product_with_order_cycle
end
end
describe 'to a cart with an order for a distributor' do
let(:product_from_other_distributor) { FactoryBot.create(:product, :distributors => [other_distributor]) }
let(:order) { FactoryBot.create(:order, :distributor => distributor) }
before do
FactoryBot.create(:line_item, :order => order, :product => product)
order.reload
subject.orders << order
subject.save!
end
it 'should create a new order and add a line item to it when product added for different distributor' do
subject.add_variant product_from_other_distributor.master.id, 3, other_distributor, nil, currency
subject.reload
subject.orders.size.should == 2
new_order_for_other_distributor = subject.orders.find { |order| order.distributor == other_distributor }
new_order_for_other_distributor.order_cycle.should be_nil
order.line_items.size.should == 1
new_order_for_other_distributor.line_items.size.should == 1
new_order_for_other_distributor.line_items.first.product.should == product_from_other_distributor
end
it 'should group line item in existing order, when product added for the same distributor' do
subject.add_variant product.master.id, 3, distributor, nil, currency
subject.orders.size.should == 1
order = subject.orders.first.reload
order.line_items.size.should == 2
order.line_items.first.product.should == product
end
it 'should create a new order for product in an order cycle' do
subject.add_variant product_with_order_cycle.master.id, 3, distributor, order_cycle, currency
subject.orders.size.should == 2
new_order_for_distributor = subject.orders.find { |order| order.order_cycle == order_cycle }
new_order_for_distributor.reload
new_order_for_distributor.line_items.first.product.should == product_with_order_cycle
end
end
describe 'existing order for distributor and order cycle' do
let(:order) { FactoryBot.create(:order, :distributor => distributor, :order_cycle => order_cycle) }
before do
subject.orders << order
subject.save!
end
it 'should group line items in existing order when added for the same distributor and order cycle' do
subject.add_variant product_with_order_cycle.master.id, 3, distributor, order_cycle, currency
subject.orders.size.should == 1
order = subject.orders.first.reload
order.line_items.size.should == 1
order.line_items.find{ |line_item| line_item.product == product_with_order_cycle }.should_not be_nil
end
it 'should create line item in new order when product added is for a different order cycle' do
order_cycle2 = create(:simple_order_cycle, distributors: [distributor], variants: [product_with_order_cycle.master])
subject.add_variant product_with_order_cycle.master.id, 3, distributor, order_cycle2, currency
subject.orders.size.should == 2
new_order_for_second_order_cycle = subject.orders.find { |order| order.order_cycle == order_cycle2 }
new_order_for_second_order_cycle.reload
new_order_for_second_order_cycle.line_items.size.should == 1
new_order_for_second_order_cycle.line_items.first.product.should == product_with_order_cycle
new_order_for_second_order_cycle.distributor.should == distributor
new_order_for_second_order_cycle.order_cycle.should == order_cycle2
end
it 'should create line_items in new order when added with different distributor, but same order_cycle' do
subject.add_variant product_with_order_cycle.master.id, 3, other_distributor, order_cycle, currency
subject.orders.size.should == 2
new_order_for_second_order_cycle = subject.orders.find { |order| order.distributor == other_distributor }
new_order_for_second_order_cycle.reload
new_order_for_second_order_cycle.line_items.size.should == 1
new_order_for_second_order_cycle.line_items.find{ |line_item| line_item.product == product_with_order_cycle }.should_not be_nil
new_order_for_second_order_cycle.order_cycle.should == order_cycle
end
end
end
end