From 42cf96e6354a9bab5b681ea12d3253bc572b49fc Mon Sep 17 00:00:00 2001
From: Matt-Yorkley <9029026+Matt-Yorkley@users.noreply.github.com>
Date: Mon, 15 Oct 2018 14:24:19 +0100
Subject: [PATCH] Disable button unless orders selected

---
 .../controllers/orders_controller.js.coffee   | 19 +++++++++++++++----
 app/assets/stylesheets/admin/orders.css.scss  |  4 ++++
 app/views/spree/admin/orders/index.html.haml  |  4 ++--
 3 files changed, 21 insertions(+), 6 deletions(-)

diff --git a/app/assets/javascripts/admin/orders/controllers/orders_controller.js.coffee b/app/assets/javascripts/admin/orders/controllers/orders_controller.js.coffee
index 6aec2e8496..842afefee6 100644
--- a/app/assets/javascripts/admin/orders/controllers/orders_controller.js.coffee
+++ b/app/assets/javascripts/admin/orders/controllers/orders_controller.js.coffee
@@ -1,4 +1,4 @@
-angular.module("admin.orders").controller "ordersCtrl", ($scope, RequestMonitor, Orders, SortOptions, $http, $window) ->
+angular.module("admin.orders").controller "ordersCtrl", ($scope, RequestMonitor, Orders, SortOptions, $http, $window, $filter) ->
   $scope.RequestMonitor = RequestMonitor
   $scope.pagination = Orders.pagination
   $scope.orders = Orders.all
@@ -8,7 +8,8 @@ angular.module("admin.orders").controller "ordersCtrl", ($scope, RequestMonitor,
     {id: 50, name: t('js.admin.orders.index.per_page', results: 50)},
     {id: 100, name: t('js.admin.orders.index.per_page', results: 100)}
   ]
-  $scope.selected = {}
+  $scope.selected_orders = {}
+  $scope.selected = false
   $scope.select_all = false
 
   $scope.initialise = ->
@@ -41,7 +42,7 @@ angular.module("admin.orders").controller "ordersCtrl", ($scope, RequestMonitor,
   $scope.toggleAll = ->
     $scope.select_all = !$scope.select_all
     $scope.orders.forEach (order) ->
-      $scope.selected[order.id] = $scope.select_all
+      $scope.selected_orders[order.id] = $scope.select_all
 
   $scope.$watch 'sortOptions', (sort) ->
     if sort && sort.predicate != ""
@@ -50,13 +51,23 @@ angular.module("admin.orders").controller "ordersCtrl", ($scope, RequestMonitor,
       $scope.fetchResults()
   , true
 
+  $scope.$watchCollection 'selected_orders', (selected_orders) ->
+    if selected_orders
+      orders_selected = false
+      angular.forEach selected_orders, (checked, order_id) ->
+        if checked
+          orders_selected = true
+          return
+
+      $scope.selected = orders_selected
+
   $scope.changePage = (newPage) ->
     $scope.page = newPage
     $scope.fetchResults(newPage)
 
   $scope.bulkInvoice = ->
     params = ''
-    angular.forEach $scope.selected, (selected, order_id) ->
+    angular.forEach $scope.selected_orders, (selected, order_id) ->
       params += 'order_ids[]='+order_id+'&' if selected
 
     $window.open('/admin/orders/bulk_invoice?'+params)
diff --git a/app/assets/stylesheets/admin/orders.css.scss b/app/assets/stylesheets/admin/orders.css.scss
index d92fc11f6f..5f53152901 100644
--- a/app/assets/stylesheets/admin/orders.css.scss
+++ b/app/assets/stylesheets/admin/orders.css.scss
@@ -108,5 +108,9 @@ table.index td.actions {
 
   button {
     float: right;
+
+    &:disabled {
+      background-color: $disabled-button;
+    }
   }
 }
diff --git a/app/views/spree/admin/orders/index.html.haml b/app/views/spree/admin/orders/index.html.haml
index 75a9a4b0fb..96cddca13b 100644
--- a/app/views/spree/admin/orders/index.html.haml
+++ b/app/views/spree/admin/orders/index.html.haml
@@ -19,7 +19,7 @@
 .row.index-controls{'ng-show' => '!RequestMonitor.loading && orders.length > 0'}
   = render partial: 'per_page_controls'
 
-  %button{'ng-click' => 'bulkInvoice()'}
+  %button{'ng-click' => 'bulkInvoice()', 'ng-disabled' => '!selected'}
     = t('.print_invoices')
 
 %table#listing_orders.index.responsive{width: "100%", 'ng-init' => 'initialise()', 'ng-show' => "!RequestMonitor.loading && orders.length > 0" }
@@ -46,7 +46,7 @@
   %tbody
     %tr{ng: {repeat: 'order in orders track by $index', class: {even: "'even'", odd: "'odd'"}}, 'ng-class' => "'state-{{order.state}}'"}
       %td.align-center
-        %input{type: 'checkbox', 'ng-model' => 'selected[order.id]'}
+        %input{type: 'checkbox', 'ng-model' => 'selected_orders[order.id]'}
       %td.align-center
         {{order.distributor_name}}
       %td.align-center