From 425674c4e5a0a67a351502ed6fa2c57bc8bf1d02 Mon Sep 17 00:00:00 2001 From: Maikel Linke Date: Wed, 29 Mar 2023 15:14:03 +1100 Subject: [PATCH] Remove unused return value of admin login helper Well, there was one use of the return helper. But I don't think that it's a very intuitive method. --- spec/support/request/authentication_helper.rb | 4 +--- spec/system/admin/enterprises_spec.rb | 3 ++- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/spec/support/request/authentication_helper.rb b/spec/support/request/authentication_helper.rb index 4a2b73cb7a..ee1aaa4ebe 100644 --- a/spec/support/request/authentication_helper.rb +++ b/spec/support/request/authentication_helper.rb @@ -4,9 +4,7 @@ module AuthenticationHelper include Warden::Test::Helpers def login_as_admin - admin_user = create(:admin_user) - login_as admin_user - admin_user + login_as create(:admin_user) end def login_as_admin_and_visit(path_visit) diff --git a/spec/system/admin/enterprises_spec.rb b/spec/system/admin/enterprises_spec.rb index 8a27a001f8..8e4202b694 100644 --- a/spec/system/admin/enterprises_spec.rb +++ b/spec/system/admin/enterprises_spec.rb @@ -22,6 +22,7 @@ describe ' end it "creating a new enterprise" do + admin = create(:admin_user) eg1 = create(:enterprise_group, name: 'eg1') eg2 = create(:enterprise_group, name: 'eg2') payment_method = create(:payment_method) @@ -29,7 +30,7 @@ describe ' enterprise_fee = create(:enterprise_fee) # Navigating - admin = login_as_admin + login_as admin visit '/admin/enterprises' click_link 'New Enterprise'