From 8f59d76eb2704a0b7567bb017e7c12380d8a89d1 Mon Sep 17 00:00:00 2001 From: Andy Brett Date: Mon, 8 Feb 2021 08:57:11 -0800 Subject: [PATCH 1/3] remove variants with no product --- db/migrate/20210202052337_migrate_variant_unit_values.rb | 3 +++ 1 file changed, 3 insertions(+) diff --git a/db/migrate/20210202052337_migrate_variant_unit_values.rb b/db/migrate/20210202052337_migrate_variant_unit_values.rb index 9c6cf46a2e..56abf49508 100644 --- a/db/migrate/20210202052337_migrate_variant_unit_values.rb +++ b/db/migrate/20210202052337_migrate_variant_unit_values.rb @@ -1,5 +1,8 @@ class MigrateVariantUnitValues < ActiveRecord::Migration def up + Spree::Variant.where(product_id: nil).find_each do |variant| + variant.destroy + end Spree::Variant.where(unit_value: [nil, Float::NAN]).find_each do |variant| variant.unit_value = 1 variant.save From 9a2bf9d333b352492339deed8c72053df9c17c12 Mon Sep 17 00:00:00 2001 From: Andy Brett Date: Mon, 8 Feb 2021 13:12:40 -0800 Subject: [PATCH 2/3] use #destroy_all --- db/migrate/20210202052337_migrate_variant_unit_values.rb | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/db/migrate/20210202052337_migrate_variant_unit_values.rb b/db/migrate/20210202052337_migrate_variant_unit_values.rb index 56abf49508..07d6f6bc1f 100644 --- a/db/migrate/20210202052337_migrate_variant_unit_values.rb +++ b/db/migrate/20210202052337_migrate_variant_unit_values.rb @@ -1,8 +1,6 @@ class MigrateVariantUnitValues < ActiveRecord::Migration def up - Spree::Variant.where(product_id: nil).find_each do |variant| - variant.destroy - end + Spree::Variant.where(product_id: nil).destroy_all Spree::Variant.where(unit_value: [nil, Float::NAN]).find_each do |variant| variant.unit_value = 1 variant.save From 50c429f3938bebed9339b0b500d9d2f78ff72452 Mon Sep 17 00:00:00 2001 From: Pau Perez Date: Tue, 9 Feb 2021 11:27:48 +0100 Subject: [PATCH 3/3] Update db/schema's timestamp after migration --- db/schema.rb | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/db/schema.rb b/db/schema.rb index aa00312da6..9f6ff5bbd7 100644 --- a/db/schema.rb +++ b/db/schema.rb @@ -11,8 +11,7 @@ # # It's strongly recommended that you check this file into your version control system. - -ActiveRecord::Schema.define(version: 20210203215049) do +ActiveRecord::Schema.define(version: 20210203214304) do # These are extensions that must be enabled in order to support this database enable_extension "plpgsql"