From 410485fbf4af2818d158f66c7a9bcc29d771bf33 Mon Sep 17 00:00:00 2001 From: Matt-Yorkley <9029026+Matt-Yorkley@users.noreply.github.com> Date: Sun, 19 Dec 2021 11:33:32 +0000 Subject: [PATCH] Use #order_failed_route in #process_order_completion! --- app/controllers/concerns/order_completion.rb | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/app/controllers/concerns/order_completion.rb b/app/controllers/concerns/order_completion.rb index d0197bef89..ecce3b66ba 100644 --- a/app/controllers/concerns/order_completion.rb +++ b/app/controllers/concerns/order_completion.rb @@ -57,7 +57,10 @@ module OrderCompletion end def process_payment_completion! - return processing_failed unless @order.process_payments! + unless @order.process_payments! + processing_failed + return redirect_to order_failed_route + end if OrderWorkflow.new(@order).next && @order.complete? processing_succeeded @@ -69,6 +72,7 @@ module OrderCompletion rescue Spree::Core::GatewayError => e gateway_error(e) processing_failed + redirect_to order_failed_route end def processing_succeeded