From 3f3c33bce6322fe3f1518a9f36573386419fa650 Mon Sep 17 00:00:00 2001
From: luisramos0 <luisramos0@gmail.com>
Date: Tue, 17 Sep 2019 15:56:53 +0100
Subject: [PATCH] Fix basic rubocop issues in newly added controller

---
 .../spree/admin/mail_methods_controller.rb          | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/app/controllers/spree/admin/mail_methods_controller.rb b/app/controllers/spree/admin/mail_methods_controller.rb
index 2cf2527592..867829c0bd 100644
--- a/app/controllers/spree/admin/mail_methods_controller.rb
+++ b/app/controllers/spree/admin/mail_methods_controller.rb
@@ -13,7 +13,7 @@ module Spree
           Spree::Config[name] = value
         end
 
-        flash[:success] = Spree.t(:successfully_updated, :resource => Spree.t(:mail_methods))
+        flash[:success] = Spree.t(:successfully_updated, resource: Spree.t(:mail_methods))
         render :edit
       end
 
@@ -23,16 +23,17 @@ module Spree
         else
           flash[:error] = Spree.t('admin.mail_methods.testmail.delivery_error')
         end
-      rescue Exception => e
-        flash[:error] = Spree.t('admin.mail_methods.testmail.error') % {:e => e}
+      rescue StandardError => e
+        flash[:error] = Spree.t('admin.mail_methods.testmail.error') % { e: e }
       ensure
         redirect_to edit_admin_mail_method_url
       end
 
       private
-        def initialize_mail_settings
-          Spree::Core::MailSettings.init
-        end
+
+      def initialize_mail_settings
+        Spree::Core::MailSettings.init
+      end
     end
   end
 end