From 3dccc17d7759d939b07faa649983ff03183bf988 Mon Sep 17 00:00:00 2001 From: Gaetan Craig-Riou Date: Wed, 10 Jul 2024 11:45:39 +1000 Subject: [PATCH] Per review, remove instance variable @query --- app/services/order_cycles/distributed_products_service.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/services/order_cycles/distributed_products_service.rb b/app/services/order_cycles/distributed_products_service.rb index 648a6a6697..e47ec7a4e3 100644 --- a/app/services/order_cycles/distributed_products_service.rb +++ b/app/services/order_cycles/distributed_products_service.rb @@ -71,8 +71,8 @@ module OrderCycles distributor.preferred_shopfront_product_sorting_method end - def supplier_property_join - @query = @query.joins(" + def supplier_property_join(query) + query.joins(" JOIN enterprises ON enterprises.id = first_variant.supplier_id LEFT OUTER JOIN producer_properties ON producer_properties.producer_id = enterprises.id ")