From 3d9542fec24203d87bd14338a6c2129cb06ceb00 Mon Sep 17 00:00:00 2001 From: Gaetan Craig-Riou Date: Fri, 30 Jun 2023 11:44:13 +1000 Subject: [PATCH] Per review, rename amount to adjustment_amount It was confusing as I was re assigning a variable given as a parameter --- app/services/voucher_adjustments_service.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/services/voucher_adjustments_service.rb b/app/services/voucher_adjustments_service.rb index aadc4bf91c..3b0201d0af 100644 --- a/app/services/voucher_adjustments_service.rb +++ b/app/services/voucher_adjustments_service.rb @@ -51,10 +51,10 @@ class VoucherAdjustmentsService tax_adjustment.save # Update the adjustment amount - amount = voucher_rate * (order.pre_discount_total - order.additional_tax_total) + adjustment_amount = voucher_rate * (order.pre_discount_total - order.additional_tax_total) adjustment.update_columns( - amount: amount, + amount: adjustment_amount, updated_at: Time.zone.now ) end