From 3d06b758922d6f48ffdf7aee90605f194e533f92 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mikael=20Norl=C3=A9n?= Date: Wed, 15 Feb 2023 10:42:28 +0100 Subject: [PATCH] Simplify customers_with_balance spec Improve variable names and use multiple expectations --- spec/queries/customers_with_balance_spec.rb | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/spec/queries/customers_with_balance_spec.rb b/spec/queries/customers_with_balance_spec.rb index b243962c85..9bf075367a 100644 --- a/spec/queries/customers_with_balance_spec.rb +++ b/spec/queries/customers_with_balance_spec.rb @@ -22,9 +22,9 @@ describe CustomersWithBalance do context 'with customers collection' do it 'returns balance' do customers = create_pair(:customer) - id_b = described_class.new(Customer.where(id: customers)).query - .map{ |c| [c.id, c.balance_value] } - expect(id_b).to eq([[customers.first.id, 0], [customers.second.id, 0]]) + query = described_class.new(Customer.where(id: customers)).query + expect(query.pluck(:id)).to eq([customers.first.id, customers.second.id]) + expect(query.map(&:balance_value)).to eq([0, 0]) end end