From 3c864a68d11fe1127bb8cffb87b8c403b331d880 Mon Sep 17 00:00:00 2001
From: Matt-Yorkley <9029026+Matt-Yorkley@users.noreply.github.com>
Date: Wed, 24 Mar 2021 18:22:56 +0000
Subject: [PATCH] Fix errors in PermittedAttributes::OrderCycle

---
 .../permitted_attributes/order_cycle.rb         | 17 +----------------
 1 file changed, 1 insertion(+), 16 deletions(-)

diff --git a/app/services/permitted_attributes/order_cycle.rb b/app/services/permitted_attributes/order_cycle.rb
index 046726a96f..f27d1cc3e9 100644
--- a/app/services/permitted_attributes/order_cycle.rb
+++ b/app/services/permitted_attributes/order_cycle.rb
@@ -35,23 +35,8 @@ module PermittedAttributes
         :tag_list,
         tags: [:text],
         enterprise_fee_ids: [],
-        variants: permitted_variant_ids
+        variants: {}
       ]
     end
-
-    # In rails 5 we will be able to permit random hash keys simply with :variants => {}
-    # See https://github.com/rails/rails/commit/e86524c0c5a26ceec92895c830d1355ae47a7034
-    #
-    # Until then, we need to create an array of variant IDs in order to permit them
-    def permitted_variant_ids
-      variant_ids(@params[:order_cycle][:incoming_exchanges]) +
-        variant_ids(@params[:order_cycle][:outgoing_exchanges])
-    end
-
-    def variant_ids(exchange_params)
-      return [] unless exchange_params
-
-      exchange_params.map { |exchange| exchange[:variants].map { |key, _value| key } }.flatten
-    end
   end
 end