From 39245d55e2b8560e5ae1f5230a5cb4e5df9a2037 Mon Sep 17 00:00:00 2001 From: Gaetan Craig-Riou Date: Fri, 9 Jan 2026 11:07:07 +1100 Subject: [PATCH] Turn defer off when loading javascript script It seems that we have functionality that depends on the order the scripts are executed. Using defer breaks that. Using defer is better performance wise so we should try to address this eventually, might need to wait till we get rid of angular. --- app/views/layouts/darkswarm.html.haml | 2 +- app/views/layouts/registration.html.haml | 2 +- app/views/spree/admin/shared/_head.html.haml | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/app/views/layouts/darkswarm.html.haml b/app/views/layouts/darkswarm.html.haml index 475cb45bff..0ea508a490 100644 --- a/app/views/layouts/darkswarm.html.haml +++ b/app/views/layouts/darkswarm.html.haml @@ -18,7 +18,7 @@ = language_meta_tags = stylesheet_pack_tag "darkswarm", "data-turbo-track": "reload", media: "screen" - = javascript_pack_tag "application", "data-turbo-track": "reload" + = javascript_pack_tag "application", "data-turbo-track": "reload", defer: false = render "layouts/shopfront_script" if @shopfront_layout = render "layouts/bugsnag_js" diff --git a/app/views/layouts/registration.html.haml b/app/views/layouts/registration.html.haml index 07f8a84ef4..38caee638b 100644 --- a/app/views/layouts/registration.html.haml +++ b/app/views/layouts/registration.html.haml @@ -16,7 +16,7 @@ = stylesheet_pack_tag "darkswarm", media: "screen" = javascript_include_tag "darkswarm/all" - = javascript_pack_tag "application" + = javascript_pack_tag "application", defer: false = csrf_meta_tags diff --git a/app/views/spree/admin/shared/_head.html.haml b/app/views/spree/admin/shared/_head.html.haml index 5da4963871..0b0b7ccad6 100644 --- a/app/views/spree/admin/shared/_head.html.haml +++ b/app/views/spree/admin/shared/_head.html.haml @@ -25,7 +25,7 @@ = render "spree/admin/shared/translations" = render "spree/admin/shared/routes" -= javascript_pack_tag "admin", "data-turbo-track": "reload" += javascript_pack_tag "admin", "data-turbo-track": "reload", defer: false %script = raw "var AUTH_TOKEN = \"#{form_authenticity_token}\";"