From 38388be4da427a56c0564b2f39f55df51a0fbd76 Mon Sep 17 00:00:00 2001 From: filipefurtad0 Date: Thu, 10 Jul 2025 11:07:26 +0100 Subject: [PATCH] Only the .env.test.local file (not tracked) should be changed This prevents contributors from inadvertently committing changes on the .env.test file (which is tracked) Reverts changes to .env.test and changes README.md accordingly --- .env.test | 3 --- docker/README.md | 2 +- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/.env.test b/.env.test index 5abea97a14..0833c82074 100644 --- a/.env.test +++ b/.env.test @@ -35,6 +35,3 @@ OPENID_REFRESH_TOKEN="dummy-refresh-token" ACTIVE_RECORD_ENCRYPTION_PRIMARY_KEY="test_primary_key" ACTIVE_RECORD_ENCRYPTION_DETERMINISTIC_KEY="test_deterministic_key" ACTIVE_RECORD_ENCRYPTION_KEY_DERIVATION_SALT="test_derivation_salt" - -# Let the tests know if they are run within a Docker container: -# DOCKER="true" diff --git a/docker/README.md b/docker/README.md index be161f6518..6a621eba2f 100644 --- a/docker/README.md +++ b/docker/README.md @@ -5,7 +5,7 @@ Docker is intended to provide a common virtual environment available to all deve ## Limitations 1. The docker environment can't directly control your host system browser, which means that browser specs (under `/spec/system/`) and email previews will not work. You may be able to find a solution with [this article](https://evilmartians.com/chronicles/system-of-a-test-setting-up-end-to-end-rails-testing). If so, please contribute! -2. You can try circumventing this by setting the option `DOCKER=true` on the `.env.test file`, which will disable the `sandbox` mode for Chrome, used for system tests. +2. You can try circumventing this by setting the option `DOCKER=true` on the `.env.test.local` file, which will disable the `sandbox` mode for Chrome, used for system tests. ## Installing Docker ### Requirements