From 3710aa2149e02701067ca35400079a50ce0f344e Mon Sep 17 00:00:00 2001 From: David Cook Date: Wed, 20 Sep 2023 16:35:12 +1000 Subject: [PATCH] Refactor spec Better to explicitly test for the change, and specify expected values. --- spec/services/sets/product_set_spec.rb | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/spec/services/sets/product_set_spec.rb b/spec/services/sets/product_set_spec.rb index 72de1ab124..536e720c3e 100644 --- a/spec/services/sets/product_set_spec.rb +++ b/spec/services/sets/product_set_spec.rb @@ -138,12 +138,11 @@ describe Sets::ProductSet do it 'updates product and variant attributes' do collection_hash[0][:sku] = "test_sku" - product_set.save - - expect(product.reload.variants.first[:sku]).to eq variants_attributes.first[:sku] - expect(product.reload.attributes).to include( - 'sku' => "test_sku" - ) + expect { + product_set.save + product.reload + }.to change { product.sku }.to("test_sku") + .and change { product.variants.first.sku }.to("123") end end end