From 366cca7984a086b992dc59a08a50877d2ede1bc7 Mon Sep 17 00:00:00 2001 From: Gaetan Craig-Riou Date: Mon, 26 Jun 2023 14:43:25 +1000 Subject: [PATCH] Prevent voucher adjustment from bein updated when update is called --- .../app/services/order_management/order/updater.rb | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/engines/order_management/app/services/order_management/order/updater.rb b/engines/order_management/app/services/order_management/order/updater.rb index fc727d7e35..47d17f9877 100644 --- a/engines/order_management/app/services/order_management/order/updater.rb +++ b/engines/order_management/app/services/order_management/order/updater.rb @@ -137,7 +137,10 @@ module OrderManagement end def update_all_adjustments - order.all_adjustments.reload.each(&:update_adjustment!) + # Voucher are modelled as a Spree::Adjustment but they don't behave like all the other + # adjustments, so we don't want voucher adjustment to be updated here. + # Calculation are handled by VoucherAdjustmentsService.calculate + order.all_adjustments.non_voucher.reload.each(&:update_adjustment!) end def before_save_hook