From 341f6c9f62b9c7338cd6984b698b06b2d6801d9d Mon Sep 17 00:00:00 2001 From: Luis Ramos Date: Sun, 9 May 2021 22:08:57 +0100 Subject: [PATCH] Now that adjustment.update! has been renamed to adjustment.update_adjustment! we can use AR's update! on adjustment --- app/models/spree/adjustment.rb | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/app/models/spree/adjustment.rb b/app/models/spree/adjustment.rb index ead01caa77..973f7facee 100644 --- a/app/models/spree/adjustment.rb +++ b/app/models/spree/adjustment.rb @@ -127,11 +127,7 @@ module Spree end def set_absolute_included_tax!(tax) - # This rubocop issue can now fixed by renaming Adjustment#update! to something else, - # then AR's update! can be used instead of update_attributes! - # rubocop:disable Rails/ActiveRecordAliases - update_attributes! included_tax: tax.round(2) - # rubocop:enable Rails/ActiveRecordAliases + update! included_tax: tax.round(2) end def display_included_tax