From 307acdd9d1d93d424f1a0498a0b6bcefe0011a0b Mon Sep 17 00:00:00 2001 From: Gaetan Craig-Riou Date: Wed, 15 Oct 2025 14:29:52 +1100 Subject: [PATCH] Per review, fixing specs descriptions --- spec/models/tag_rule/filter_order_cycles_spec.rb | 2 +- spec/models/tag_rule/filter_payment_methods_spec.rb | 2 +- spec/models/tag_rule/filter_products_spec.rb | 2 +- spec/models/tag_rule/filter_shipping_methods_spec.rb | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/spec/models/tag_rule/filter_order_cycles_spec.rb b/spec/models/tag_rule/filter_order_cycles_spec.rb index 76bbb17ef8..c4eded6125 100644 --- a/spec/models/tag_rule/filter_order_cycles_spec.rb +++ b/spec/models/tag_rule/filter_order_cycles_spec.rb @@ -17,7 +17,7 @@ RSpec.describe TagRule::FilterOrderCycles do end end - describe "#reject_matched?" do + describe "#tags_match?" do context "when the exchange is nil" do before do allow(tag_rule).to receive(:exchange_for) { nil } diff --git a/spec/models/tag_rule/filter_payment_methods_spec.rb b/spec/models/tag_rule/filter_payment_methods_spec.rb index f9776d4d36..fe7b4056b2 100644 --- a/spec/models/tag_rule/filter_payment_methods_spec.rb +++ b/spec/models/tag_rule/filter_payment_methods_spec.rb @@ -16,7 +16,7 @@ RSpec.describe TagRule::FilterPaymentMethods do end end - describe "#tag_match?" do + describe "#tags_match?" do context "when the payment method is nil" do it "returns false" do expect(tag_rule.tags_match?(nil)).to be false diff --git a/spec/models/tag_rule/filter_products_spec.rb b/spec/models/tag_rule/filter_products_spec.rb index 0595e6e0e3..58e0ec7409 100644 --- a/spec/models/tag_rule/filter_products_spec.rb +++ b/spec/models/tag_rule/filter_products_spec.rb @@ -14,7 +14,7 @@ RSpec.describe TagRule::FilterProducts do end end - describe "determining whether tags match for a given variant" do + describe "#tags_match?" do let(:variant_tags) { "my_tag" } context "when the variant is nil" do diff --git a/spec/models/tag_rule/filter_shipping_methods_spec.rb b/spec/models/tag_rule/filter_shipping_methods_spec.rb index ffae35cf15..022df21ee0 100644 --- a/spec/models/tag_rule/filter_shipping_methods_spec.rb +++ b/spec/models/tag_rule/filter_shipping_methods_spec.rb @@ -16,7 +16,7 @@ RSpec.describe TagRule::FilterShippingMethods do end end - describe "#tag_match?" do + describe "#tags_match?" do context "when the shipping method is nil" do it "returns false" do expect(tag_rule.tags_match?(nil)).to be false