From 2bd2bea7b7113c67e3917b71003fb3183ce89f6d Mon Sep 17 00:00:00 2001 From: David Cook Date: Fri, 24 Nov 2023 16:14:28 +1100 Subject: [PATCH] Remove need for class Generally, I would say that style rules should have a BEM-style class name, but in this case it's terribly convenient to support a tags directly. --- .../admin/products_v3/components/_product_actions.html.haml | 6 +++--- .../css/admin_v3/components/vertical_ellipsis_menu.scss | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/app/views/admin/products_v3/components/_product_actions.html.haml b/app/views/admin/products_v3/components/_product_actions.html.haml index 8152ec1584..cd50dd497b 100644 --- a/app/views/admin/products_v3/components/_product_actions.html.haml +++ b/app/views/admin/products_v3/components/_product_actions.html.haml @@ -2,7 +2,7 @@ %i.fa.fa-ellipsis-v{ "data-action": "click->vertical-ellipsis-menu#toggle" } .vertical-ellipsis-menu-content{ "data-vertical-ellipsis-menu-target": "content" } - if defined?(variant) - = link_to t('admin.products_page.actions.edit'), edit_admin_product_variant_path(product, variant), class: "vertical-ellipsis-menu-content-item" + = link_to t('admin.products_page.actions.edit'), edit_admin_product_variant_path(product, variant) - else - = link_to t('admin.products_page.actions.edit'), edit_admin_product_path(product), class: "vertical-ellipsis-menu-content-item" - = link_to t('admin.products_page.actions.clone'), clone_admin_product_path(product), class: "vertical-ellipsis-menu-content-item" + = link_to t('admin.products_page.actions.edit'), edit_admin_product_path(product) + = link_to t('admin.products_page.actions.clone'), clone_admin_product_path(product) diff --git a/app/webpacker/css/admin_v3/components/vertical_ellipsis_menu.scss b/app/webpacker/css/admin_v3/components/vertical_ellipsis_menu.scss index de35c98455..9434a94bc4 100644 --- a/app/webpacker/css/admin_v3/components/vertical_ellipsis_menu.scss +++ b/app/webpacker/css/admin_v3/components/vertical_ellipsis_menu.scss @@ -30,7 +30,7 @@ display: block; } - .vertical-ellipsis-menu-content-item { + & > a { display: block; padding: 5px 10px; cursor: pointer;