From 2aa6c70dc6c2a96eafe7a9d8020126b172f95225 Mon Sep 17 00:00:00 2001 From: Luis Ramos Date: Fri, 24 Jul 2020 13:15:36 +0100 Subject: [PATCH] Remove select from relation This relation is only used above for a call to empty? so we don't need to worry about the select part of the query, specially not introducing an expensive DISTINCT --- .../api/admin/for_order_cycle/enterprise_serializer.rb | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/app/serializers/api/admin/for_order_cycle/enterprise_serializer.rb b/app/serializers/api/admin/for_order_cycle/enterprise_serializer.rb index 7e6fed44f7..fecf675c5f 100644 --- a/app/serializers/api/admin/for_order_cycle/enterprise_serializer.rb +++ b/app/serializers/api/admin/for_order_cycle/enterprise_serializer.rb @@ -31,8 +31,7 @@ class Api::Admin::ForOrderCycle::EnterpriseSerializer < ActiveModel::Serializer products_relation = object.supplied_products if order_cycle.prefers_product_selection_from_coordinator_inventory_only? products_relation = products_relation. - visible_for(order_cycle.coordinator). - select('DISTINCT spree_products.*') + visible_for(order_cycle.coordinator) end products_relation end