From 29a4bf88d7520b2e26615fa7e44a9a6a27c65ef7 Mon Sep 17 00:00:00 2001 From: Gaetan Craig-Riou Date: Tue, 12 Sep 2023 14:13:04 +0200 Subject: [PATCH] DRY up specs --- .../sales_tax_totals_by_order_spec.rb | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/spec/system/admin/reports/sales_tax/sales_tax_totals_by_order_spec.rb b/spec/system/admin/reports/sales_tax/sales_tax_totals_by_order_spec.rb index f9ce7e273e..571d3862ad 100644 --- a/spec/system/admin/reports/sales_tax/sales_tax_totals_by_order_spec.rb +++ b/spec/system/admin/reports/sales_tax/sales_tax_totals_by_order_spec.rb @@ -104,9 +104,7 @@ describe "Sales Tax Totals By order" do end it "generates the report" do - login_as admin - visit admin_reports_path - click_on "Sales Tax Totals By Order" + visit_sales_tax_totals_by_order expect(page).to have_button("Go") click_on "Go" @@ -165,10 +163,9 @@ describe "Sales Tax Totals By order" do order.recreate_all_fees! OrderWorkflow.new(order).complete! end + it "generates the report" do - login_as admin - visit admin_reports_path - click_on "Sales Tax Totals By Order" + visit_sales_tax_totals_by_order expect(page).to have_button("Go") click_on "Go" @@ -334,9 +331,7 @@ describe "Sales Tax Totals By order" do order2.recreate_all_fees! OrderWorkflow.new(order2).complete! - login_as admin - visit admin_reports_path - click_on "Sales Tax Totals By Order" + visit_sales_tax_totals_by_order end it "should load all the orders" do @@ -467,6 +462,12 @@ describe "Sales Tax Totals By order" do end end + def visit_sales_tax_totals_by_order + login_as admin + visit admin_reports_path + click_on "Sales Tax Totals By Order" + end + def generate_report click_on "Go" wait_for_download