From cef1092a2d8bbe2152511d6531cbe35997071625 Mon Sep 17 00:00:00 2001 From: Maikel Linke Date: Fri, 15 Oct 2021 16:02:52 +1100 Subject: [PATCH 1/2] Avoid state leakage from one spec to others Activating Stripe meant that other specs were trying to load the Stripe JS code without setting up Stripe correctly. That lead to JS errors in the console. --- spec/system/consumer/account/cards_spec.rb | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/spec/system/consumer/account/cards_spec.rb b/spec/system/consumer/account/cards_spec.rb index 91ce8427c8..2b5538fe06 100644 --- a/spec/system/consumer/account/cards_spec.rb +++ b/spec/system/consumer/account/cards_spec.rb @@ -27,8 +27,9 @@ describe "Credit Cards", js: true do before do login_as user - Stripe.api_key = "sk_test_12345" - Stripe.publishable_key = "some_token" + allow(Stripe).to receive(:api_key).and_return("sk_test_12345") + allow(Stripe.config).to receive(:api_key).and_return("sk_test_12345") + allow(Stripe).to receive(:publishable_key).and_return("some_token") Spree::Config.set(stripe_connect_enabled: true) stub_request(:get, "https://api.stripe.com/v1/customers/cus_AZNMJ"). From c89cf3683157f2c418d1b5deea5a7e7d1590f69a Mon Sep 17 00:00:00 2001 From: Maikel Linke Date: Fri, 8 Oct 2021 17:45:40 +1100 Subject: [PATCH 2/2] Raise JavaScript errors within system specs (again) Re-raising console errors helps us to find subtle bugs. --- spec/system/support/cuprite_setup.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spec/system/support/cuprite_setup.rb b/spec/system/support/cuprite_setup.rb index 133287ab1e..f75d42b7b0 100644 --- a/spec/system/support/cuprite_setup.rb +++ b/spec/system/support/cuprite_setup.rb @@ -14,7 +14,7 @@ Capybara.register_driver(:cuprite) do |app| url_whitelist: ["http://localhost", "http://0.0.0.0", "http://127.0.0.1"], inspector: true, headless: true, - js_errors: false, + js_errors: true, } ) end