diff --git a/spec/lib/open_food_network/order_cycle_management_report_spec.rb b/spec/lib/open_food_network/order_cycle_management_report_spec.rb index c010d6f253..c68daa3b61 100644 --- a/spec/lib/open_food_network/order_cycle_management_report_spec.rb +++ b/spec/lib/open_food_network/order_cycle_management_report_spec.rb @@ -5,7 +5,7 @@ include AuthenticationWorkflow module OpenFoodNetwork describe OrderCycleManagementReport do context "as a site admin" do - let(:user) do + let(:user) do user = create(:user) user.spree_roles << Spree::Role.find_or_create_by_name!("admin") user @@ -28,7 +28,7 @@ module OpenFoodNetwork end context "as an enterprise user" do - let!(:user) { create_enterprise_user } + let!(:user) { create_enterprise_user } subject { OrderCycleManagementReport.new user } @@ -71,13 +71,12 @@ module OpenFoodNetwork let!(:sm1) { create(:shipping_method, name: "ship1") } let!(:order1) { create(:order, shipping_method: sm1, order_cycle: oc1) } let!(:payment1) { create(:payment, order: order1, payment_method: pm1) } - + it "returns all orders sans-params" do subject.filter(orders).should == orders end it "filters to a specific order cycle" do - oc2 = create(:simple_order_cycle) order2 = create(:order, order_cycle: oc2) @@ -86,7 +85,6 @@ module OpenFoodNetwork end it "filters to a payment method" do - pm2 = create(:payment_method, name: "PM2") order2 = create(:order) payment2 = create(:payment, order: order2, payment_method: pm2) @@ -96,7 +94,6 @@ module OpenFoodNetwork end it "filters to a shipping method" do - sm2 = create(:shipping_method, name: "ship2") order2 = create(:order, shipping_method: sm2) @@ -105,16 +102,11 @@ module OpenFoodNetwork end it "should do all the filters at once" do - - subject.stub(:params).and_return( - order_cycle_id: oc1.id, - shipping_method_name: sm1.name, - payment_method_name: pm1.name) + subject.stub(:params).and_return(order_cycle_id: oc1.id, + shipping_method_name: sm1.name, + payment_method_name: pm1.name) subject.filter(orders).should == [order1] - - end - - + end end end end