diff --git a/lib/reporting/reports/enterprise_fee_summary/summarizer.rb b/lib/reporting/reports/enterprise_fee_summary/summarizer.rb index dd223b72dd..d7651f69d4 100644 --- a/lib/reporting/reports/enterprise_fee_summary/summarizer.rb +++ b/lib/reporting/reports/enterprise_fee_summary/summarizer.rb @@ -31,7 +31,7 @@ module Reporting return DataRepresentations::PaymentMethodFee if for_payment_method? return DataRepresentations::ShippingMethodFee if for_shipping_method? - enterprise_fee_adjustment_presentation_klass if for_enterprise_fee? + enterprise_fee_adjustment_presentation_klass end def enterprise_fee_adjustment_presentation_klass @@ -50,10 +50,6 @@ module Reporting data["shipping_method_name"].present? end - def for_enterprise_fee? - data["fee_name"].present? - end - def for_coordinator_fee? data["placement_enterprise_role"] == "coordinator" end diff --git a/spec/lib/reports/enterprise_fee_summary/summarizer_spec.rb b/spec/lib/reports/enterprise_fee_summary/summarizer_spec.rb new file mode 100644 index 0000000000..9070089609 --- /dev/null +++ b/spec/lib/reports/enterprise_fee_summary/summarizer_spec.rb @@ -0,0 +1,43 @@ +# frozen_string_literal: true + +require "spec_helper" + +describe Reporting::Reports::EnterpriseFeeSummary::Summarizer do + let(:row) { + { + "total_amount" => 1, "payment_method_name" => nil, + "shipping_method_name" => nil, "hub_name" => "Kimchi Hub", + "enterprise_name" => nil, "fee_type" => nil, + "customer_name" => "Fermented Greens", + "customer_email" => "kimchi@example.com", "fee_name" => nil, + "tax_category_name" => nil, + "enterprise_fee_inherits_tax_category" => nil, + "product_tax_category_name" => nil, + "placement_enterprise_role" => nil, + "adjustment_adjustable_type" => nil, + "adjustment_source_distributor_name" => nil, + "incoming_exchange_enterprise_name" => nil, + "outgoing_exchange_enterprise_name" => nil, + "id" => nil + } + } + + it "represents a transaction fee" do + data = row.merge( + "payment_method_name" => "cash", + "adjustment_adjustable_type" => "Spree::Payment", + ) + summarizer = described_class.new(data) + expect(summarizer.fee_type).to eq "Payment Transaction" + end + + it "represents an enterprise fee without name" do + data = row.merge( + "fee_name" => nil, + "placement_enterprise_role" => "coordinator", + "adjustment_adjustable_type" => "Spree::LineItem", + ) + summarizer = described_class.new(data) + expect(summarizer.fee_type).to eq nil + end +end