From 2711736004257201f63fa3c52217f952573e288c Mon Sep 17 00:00:00 2001 From: Luis Ramos Date: Tue, 18 Feb 2020 10:49:41 +0000 Subject: [PATCH] Use Array#join and make code simpler --- .../admin/utils/services/errors_parser.js.coffee | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/app/assets/javascripts/admin/utils/services/errors_parser.js.coffee b/app/assets/javascripts/admin/utils/services/errors_parser.js.coffee index 87a83360a1..f03ce54467 100644 --- a/app/assets/javascripts/admin/utils/services/errors_parser.js.coffee +++ b/app/assets/javascripts/admin/utils/services/errors_parser.js.coffee @@ -7,20 +7,15 @@ angular.module("admin.utils").factory "ErrorsParser", -> errorsString = "" if errors.length > 0 # it is an array of errors - errorsString = this.arrayToString(errors) + errorsString = errors.join("\n") else # it is a hash of errors keys = Object.keys(errors) for key in keys - errorsString += this.arrayToString(errors[key]) + errorsString += errors[key].join("\n") + "\n" this.defaultIfEmpty(errorsString, defaultContent) - arrayToString: (array) => - string = "" - string += entry + "\n" for entry in array - string - defaultIfEmpty: (content, defaultContent) => return defaultContent if content == "" content