From 207cc8908a47eff6b85a740ddbba8f0e5a485b4d Mon Sep 17 00:00:00 2001 From: Maikel Linke Date: Mon, 6 Dec 2021 16:36:38 +1100 Subject: [PATCH] Remove useless assignments Rubocop highlighted this. The todo list actually contains these files but somehow the cop still runs and reports these as violations. --- app/models/spree/taxon.rb | 2 +- lib/spree/core/controller_helpers/common.rb | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/app/models/spree/taxon.rb b/app/models/spree/taxon.rb index f17bb48f97..81b9f8e824 100644 --- a/app/models/spree/taxon.rb +++ b/app/models/spree/taxon.rb @@ -56,7 +56,7 @@ module Spree def pretty_name ancestor_chain = ancestors.inject("") do |name, ancestor| - name += "#{ancestor.name} -> " + name + "#{ancestor.name} -> " end ancestor_chain + name.to_s end diff --git a/lib/spree/core/controller_helpers/common.rb b/lib/spree/core/controller_helpers/common.rb index 27684873b4..28090659b6 100644 --- a/lib/spree/core/controller_helpers/common.rb +++ b/lib/spree/core/controller_helpers/common.rb @@ -66,7 +66,7 @@ module Spree # The layout to render can be set inside Spree configuration with the +:layout+ option. # Default layout is: +app/views/spree/layouts/spree_application+ def get_layout - layout ||= Spree::Config[:layout] + Spree::Config[:layout] end end end