From 2008c10c6fd75fe50730cfcbd49e965c5b75f27b Mon Sep 17 00:00:00 2001 From: Sebastian Castro Date: Wed, 27 Apr 2022 08:33:35 +0200 Subject: [PATCH] Reports: use field name as header instead of translated value for raw renders (csv, json) --- lib/reporting/report_headers_builder.rb | 2 ++ spec/lib/reports/report_spec.rb | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/reporting/report_headers_builder.rb b/lib/reporting/report_headers_builder.rb index 7d3a6b8e29..e20d04c29b 100644 --- a/lib/reporting/report_headers_builder.rb +++ b/lib/reporting/report_headers_builder.rb @@ -29,6 +29,8 @@ module Reporting private def translate_header(key) + return key.to_s if report.raw_render? + # Quite some headers use currency interpolation, so providing it by default default_params = { currency: currency_symbol, currency_symbol: currency_symbol } report.custom_headers[key] || I18n.t("report_header_#{key}", **default_params) diff --git a/spec/lib/reports/report_spec.rb b/spec/lib/reports/report_spec.rb index e197fd8f97..9f7fcc3ad5 100644 --- a/spec/lib/reports/report_spec.rb +++ b/spec/lib/reports/report_spec.rb @@ -79,7 +79,7 @@ module Reporting end describe "fields_to_hide" do - let(:params) { { fields_to_hide: [:product], report_format: 'json' } } + let(:params) { { fields_to_hide: [:product] } } it "works" do @expected_headers = ['Hub', 'Price']