From 1fde91e6ff8e6e31948876e5aebe3379f4e10f09 Mon Sep 17 00:00:00 2001 From: Gaetan Craig-Riou Date: Wed, 15 May 2024 10:07:40 +1000 Subject: [PATCH] Update Webmock and VCR config as per Knapsack recommendation See : https://github.com/KnapsackPro/knapsack_pro-ruby/blob/master/CHANGELOG.md#720 --- spec/base_spec_helper.rb | 2 +- spec/support/vcr_setup.rb | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/spec/base_spec_helper.rb b/spec/base_spec_helper.rb index 11e2fae0ee..6a307e9c3c 100644 --- a/spec/base_spec_helper.rb +++ b/spec/base_spec_helper.rb @@ -32,7 +32,7 @@ require 'webmock/rspec' WebMock.enable! WebMock.disable_net_connect!( allow_localhost: true, - allow: ['chromedriver.storage.googleapis.com', 'api.knapsackpro.com'] + allow: ['chromedriver.storage.googleapis.com'] ) # Requires supporting ruby files with custom matchers and macros, etc, diff --git a/spec/support/vcr_setup.rb b/spec/support/vcr_setup.rb index 1b554f52f2..5d5c155e27 100644 --- a/spec/support/vcr_setup.rb +++ b/spec/support/vcr_setup.rb @@ -7,7 +7,7 @@ VCR.configure do |config| config.hook_into :webmock config.ignore_localhost = true config.configure_rspec_metadata! - config.ignore_hosts('localhost', '127.0.0.1', '0.0.0.0', 'api.knapsackpro.com') + config.ignore_localhost = true # Filter sensitive environment variables %w[