From 0721800f5683447dc909bed7d74a5d2730e882a8 Mon Sep 17 00:00:00 2001 From: Matt-Yorkley <9029026+Matt-Yorkley@users.noreply.github.com> Date: Wed, 5 Jan 2022 16:20:29 +0000 Subject: [PATCH 1/3] Remove jsuri.js --- .../javascripts/admin/spree/spree.js.coffee | 15 ++++++--------- vendor/assets/javascripts/jsuri.js | 2 -- 2 files changed, 6 insertions(+), 11 deletions(-) delete mode 100644 vendor/assets/javascripts/jsuri.js diff --git a/app/assets/javascripts/admin/spree/spree.js.coffee b/app/assets/javascripts/admin/spree/spree.js.coffee index c905ff48e7..b1d155127e 100644 --- a/app/assets/javascripts/admin/spree/spree.js.coffee +++ b/app/assets/javascripts/admin/spree/spree.js.coffee @@ -1,13 +1,10 @@ -#= require jsuri - class window.Spree # Helper function to take a URL and add query parameters to it - @url: (uri, query) -> - if uri.path == undefined - uri = new Uri(uri) - if query - $.each query, (key, value) -> - uri.addQueryParam(key, value) + @url: (uri) -> + if uri.pathname == undefined + uri = new URL(uri.toString()) if Spree.api_key - uri.addQueryParam('token', Spree.api_key) + params = new URLSearchParams(uri.search) + params.append('token', Spree.api_key) + return uri diff --git a/vendor/assets/javascripts/jsuri.js b/vendor/assets/javascripts/jsuri.js deleted file mode 100644 index dcf60f9796..0000000000 --- a/vendor/assets/javascripts/jsuri.js +++ /dev/null @@ -1,2 +0,0 @@ -/*! jsUri v1.1.1 | https://github.com/derek-watson/jsUri */ -var Query=function(a){"use strict";var b=function(a){var b=[],c,d,e,f;if(typeof a=="undefined"||a===null||a==="")return b;a.indexOf("?")===0&&(a=a.substring(1)),d=a.toString().split(/[&;]/);for(c=0;c0&&(a+="&"),a+=d.join("=");return a.length>0?"?"+a:a},e=function(a){a=decodeURIComponent(a),a=a.replace("+"," ");return a},f=function(a){var b,d;for(d=0;d0&&c.push([a,b]);return this},j=function(a,b,d){var f=-1,g,j;if(arguments.length===3){for(g=0;g Date: Wed, 5 Jan 2022 16:35:17 +0000 Subject: [PATCH 2/3] Update uses of (removed) jsuri interface --- .../admin/spree/taxons/taxon_tree_menu.js.coffee | 3 +-- .../javascripts/admin/spree/taxons/taxonomy.js.coffee | 8 ++++---- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/app/assets/javascripts/admin/spree/taxons/taxon_tree_menu.js.coffee b/app/assets/javascripts/admin/spree/taxons/taxon_tree_menu.js.coffee index 75135cdfcc..7fa04871ab 100644 --- a/app/assets/javascripts/admin/spree/taxons/taxon_tree_menu.js.coffee +++ b/app/assets/javascripts/admin/spree/taxons/taxon_tree_menu.js.coffee @@ -4,8 +4,7 @@ root.taxon_tree_menu = (obj, context) -> base_url = Spree.url(Spree.routes.taxonomy_taxons_path) admin_base_url = Spree.url(Spree.routes.admin_taxonomy_taxons_path) - edit_url = admin_base_url.clone() - edit_url.setPath(edit_url.path() + '/' + obj.attr("id") + "/edit"); + edit_url = Spree.url(Spree.routes.admin_taxonomy_taxons_path + '/' + obj.attr("id") + "/edit"); create: label: " " + Spree.translations.add, diff --git a/app/assets/javascripts/admin/spree/taxons/taxonomy.js.coffee b/app/assets/javascripts/admin/spree/taxons/taxonomy.js.coffee index 9ba35d692b..21f6a8b782 100644 --- a/app/assets/javascripts/admin/spree/taxons/taxonomy.js.coffee +++ b/app/assets/javascripts/admin/spree/taxons/taxonomy.js.coffee @@ -9,7 +9,7 @@ handle_move = (e, data) -> new_parent = data.rslt.np url = Spree.url(base_url).clone() - url.setPath url.path() + '/' + node.attr("id") + url.pathname = url.pathname + '/' + node.attr("id") $.ajax type: "POST", dataType: "json", @@ -41,7 +41,7 @@ handle_rename = (e, data) -> name = data.rslt.new_name url = Spree.url(base_url).clone() - url.setPath(url.path() + '/' + node.attr("id")) + url.pathname = url.pathname + '/' + node.attr("id") $.ajax type: "POST", @@ -73,7 +73,7 @@ root.setup_taxonomy_tree = (taxonomy_id) -> root.base_url = Spree.url(Spree.routes.taxonomy_taxons_path) $.ajax - url: base_url.path().replace("/taxons", "/jstree"), + url: base_url.pathname.replace("/taxons", "/jstree"), success: (taxonomy) -> last_rollback = null @@ -82,7 +82,7 @@ root.setup_taxonomy_tree = (taxonomy_id) -> data: taxonomy, ajax: url: (e) -> - base_url.path() + '/' + e.attr('id') + '/jstree' + base_url.pathname + '/' + e.attr('id') + '/jstree' themes: theme: "apple", url: "/assets/jquery.jstree/themes/apple/style.css" From 14a62f5d4978a4d101d82154317ddfc4d45df4de Mon Sep 17 00:00:00 2001 From: Matt-Yorkley <9029026+Matt-Yorkley@users.noreply.github.com> Date: Wed, 5 Jan 2022 17:33:59 +0000 Subject: [PATCH 3/3] Change paths helpers to urls --- .../admin/spree/taxons/taxon_tree_menu.js.coffee | 6 +++--- .../javascripts/admin/spree/taxons/taxonomy.js.coffee | 2 +- app/views/spree/admin/shared/_routes.html.erb | 8 ++++---- app/views/spree/admin/taxonomies/edit.haml | 4 ++-- 4 files changed, 10 insertions(+), 10 deletions(-) diff --git a/app/assets/javascripts/admin/spree/taxons/taxon_tree_menu.js.coffee b/app/assets/javascripts/admin/spree/taxons/taxon_tree_menu.js.coffee index 7fa04871ab..dca01a3aa3 100644 --- a/app/assets/javascripts/admin/spree/taxons/taxon_tree_menu.js.coffee +++ b/app/assets/javascripts/admin/spree/taxons/taxon_tree_menu.js.coffee @@ -2,9 +2,9 @@ root = exports ? this root.taxon_tree_menu = (obj, context) -> - base_url = Spree.url(Spree.routes.taxonomy_taxons_path) - admin_base_url = Spree.url(Spree.routes.admin_taxonomy_taxons_path) - edit_url = Spree.url(Spree.routes.admin_taxonomy_taxons_path + '/' + obj.attr("id") + "/edit"); + base_url = Spree.url(Spree.routes.taxonomy_taxons) + admin_base_url = Spree.url(Spree.routes.admin_taxonomy_taxons) + edit_url = Spree.url(Spree.routes.admin_taxonomy_taxons + '/' + obj.attr("id") + "/edit"); create: label: " " + Spree.translations.add, diff --git a/app/assets/javascripts/admin/spree/taxons/taxonomy.js.coffee b/app/assets/javascripts/admin/spree/taxons/taxonomy.js.coffee index 21f6a8b782..6a8d902caa 100644 --- a/app/assets/javascripts/admin/spree/taxons/taxonomy.js.coffee +++ b/app/assets/javascripts/admin/spree/taxons/taxonomy.js.coffee @@ -70,7 +70,7 @@ root = exports ? this root.setup_taxonomy_tree = (taxonomy_id) -> if taxonomy_id != undefined # this is defined within admin/taxonomies/edit - root.base_url = Spree.url(Spree.routes.taxonomy_taxons_path) + root.base_url = Spree.url(Spree.routes.taxonomy_taxons) $.ajax url: base_url.pathname.replace("/taxons", "/jstree"), diff --git a/app/views/spree/admin/shared/_routes.html.erb b/app/views/spree/admin/shared/_routes.html.erb index 418359b5e7..a0a854781f 100644 --- a/app/views/spree/admin/shared/_routes.html.erb +++ b/app/views/spree/admin/shared/_routes.html.erb @@ -6,9 +6,9 @@ Spree.routes = {} } Spree.routes = <%== { - :variants_search => spree.admin_search_variants_path(:format => 'json'), - :taxons_search => main_app.api_v0_taxons_path(:format => 'json'), - :orders_api => main_app.api_v0_orders_path, - :states_search => main_app.api_v0_states_path(:format => 'json') + :variants_search => spree.admin_search_variants_url(:format => 'json'), + :taxons_search => main_app.api_v0_taxons_url(:format => 'json'), + :orders_api => main_app.api_v0_orders_url, + :states_search => main_app.api_v0_states_url(:format => 'json') }.to_json %>; diff --git a/app/views/spree/admin/taxonomies/edit.haml b/app/views/spree/admin/taxonomies/edit.haml index 1f11fbb56c..4131f2571f 100755 --- a/app/views/spree/admin/taxonomies/edit.haml +++ b/app/views/spree/admin/taxonomies/edit.haml @@ -17,8 +17,8 @@ = label_tag nil, t("spree.tree") %br/ :javascript - Spree.routes.taxonomy_taxons_path = "#{main_app.api_v0_taxonomy_taxons_path(@taxonomy)}"; - Spree.routes.admin_taxonomy_taxons_path = "#{spree.admin_taxonomy_taxons_path(@taxonomy)}"; + Spree.routes.taxonomy_taxons = "#{main_app.api_v0_taxonomy_taxons_url(@taxonomy)}"; + Spree.routes.admin_taxonomy_taxons = "#{spree.admin_taxonomy_taxons_url(@taxonomy)}"; #taxonomy_tree.tree #progress{style: "display:none;"} = image_pack_tag 'select2-spinner.gif', title: 'Spinner', style: "vertical-align:bottom;"