diff --git a/lib/open_food_network/order_cycle_permissions.rb b/lib/open_food_network/order_cycle_permissions.rb index 30bb031852..a87964a835 100644 --- a/lib/open_food_network/order_cycle_permissions.rb +++ b/lib/open_food_network/order_cycle_permissions.rb @@ -153,11 +153,12 @@ module OpenFoodNetwork end def all_incoming_editable_variants - valid_suppliers = visible_enterprises.map do |enterprise| - enterprise.id if user_manages_coordinator_or(enterprise) - end + valid_suppliers = visible_enterprises.select do |enterprise| + user_manages_coordinator_or(enterprise) + end.map(&:id) Spree::Variant.includes(product: :supplier). + select("spree_variants.id, spree_products.supplier_id"). joins(:product).where(spree_products: { supplier_id: valid_suppliers }) end