From 192fd95a18a5bf0e603a7c7299aec135d504787d Mon Sep 17 00:00:00 2001
From: Ana Nunes da Silva <ananunesdasilva@gmail.com>
Date: Tue, 9 Jul 2024 11:16:28 +0100
Subject: [PATCH] Remove sale session methods; memoize sales data uniq by
 producers

---
 .../services/affiliate_sales_data_builder.rb  | 34 +++++--------------
 1 file changed, 8 insertions(+), 26 deletions(-)

diff --git a/engines/dfc_provider/app/services/affiliate_sales_data_builder.rb b/engines/dfc_provider/app/services/affiliate_sales_data_builder.rb
index 12bb19ba29..791adf9c10 100644
--- a/engines/dfc_provider/app/services/affiliate_sales_data_builder.rb
+++ b/engines/dfc_provider/app/services/affiliate_sales_data_builder.rb
@@ -24,27 +24,19 @@ class AffiliateSalesDataBuilder < DfcBuilder
     end
 
     def build_producers
-      sales_data
-        .uniq(&:producer_id)
-        .map { |sale| build_producer(sale) }
+      sales_data_uniq_producers.map { |sale| build_producer(sale) }
     end
 
     def build_supplied_products
-      sales_data
-        .uniq(&:producer_id)
-        .map { |sale| build_supplied_product(sale) }
+      sales_data_uniq_producers.map { |sale| build_supplied_product(sale) }
     end
 
     def build_catalogue_items
-      sales_data
-        .uniq(&:producer_id)
-        .map { |sale| build_catalogue_item(sale) }
+      sales_data_uniq_producers.map { |sale| build_catalogue_item(sale) }
     end
 
     def build_offers
-      sales_data
-        .uniq(&:producer_id)
-        .map { |sale| build_offer(sale) }
+      sales_data_uniq_producers.map { |sale| build_offer(sale) }
     end
 
     def build_order_lines
@@ -55,10 +47,6 @@ class AffiliateSalesDataBuilder < DfcBuilder
       sales_data.map { |sale| build_order(sale) }
     end
 
-    # def build_sale_sessions
-    #   sales_data.map { |sale| build_sale_session(sale) }
-    # end
-
     private
 
     def build_enterprise(id)
@@ -136,16 +124,6 @@ class AffiliateSalesDataBuilder < DfcBuilder
         urls.enterprise_order_url(sale.producer_id, sale.order_id),
         number: nil,
         date: sale.order_date.strftime("%Y-%m-%d")
-        # saleSession: build_sale_session(sale)
-      )
-    end
-
-    def build_sale_session(sale)
-      DataFoodConsortium::Connector::SaleSession.new(
-        urls.enterprise_sale_session_url(sale.producer_id, sale.line_item_id),
-        beginDate: nil,
-        endDate: nil,
-        quantity: nil
       )
     end
 
@@ -163,6 +141,10 @@ class AffiliateSalesDataBuilder < DfcBuilder
       )
     end
 
+    def sales_data_uniq_producers
+      @sales_data_uniq_producers ||= sales_data.uniq(&:producer_id)
+    end
+
     def sales_data
       @sales_data ||= AffiliateSalesQuery.call
     end