From 17da66b72a1fdd913d444b3ebc890f4981bdfaa9 Mon Sep 17 00:00:00 2001 From: David Cook Date: Fri, 7 Jul 2023 14:22:36 +1000 Subject: [PATCH] Update contents of variable directly Also, it makes the line shorter, allowing us to use one-line if syntax :) --- lib/reporting/report_rows_builder.rb | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/lib/reporting/report_rows_builder.rb b/lib/reporting/report_rows_builder.rb index e1b95bdece..bc444ac09e 100644 --- a/lib/reporting/report_rows_builder.rb +++ b/lib/reporting/report_rows_builder.rb @@ -45,9 +45,7 @@ module Reporting OpenStruct.new(item: item, full_row: row, row: @builder.slice_and_format_row(row)) } - if @report.skip_duplicate_rows? - @computed_data = @computed_data.uniq { |data| data.row.to_h.values } - end + @computed_data.uniq! { |data| data.row.to_h.values } if @report.skip_duplicate_rows? @computed_data end