From 17afdb591291469b7fc01c33af7ed6f79984c1ff Mon Sep 17 00:00:00 2001 From: Maikel Linke Date: Mon, 29 Aug 2022 15:31:18 +1000 Subject: [PATCH] Update rubocop config to avoid deprecation --- .rubocop_styleguide.yml | 2 +- .rubocop_todo.yml | 221 +++++++++++++--------------------------- 2 files changed, 71 insertions(+), 152 deletions(-) diff --git a/.rubocop_styleguide.yml b/.rubocop_styleguide.yml index e9d0ab65e3..42857db556 100644 --- a/.rubocop_styleguide.yml +++ b/.rubocop_styleguide.yml @@ -23,7 +23,7 @@ Metrics: Enabled: true Metrics/BlockLength: - IgnoredMethods: [ + AllowedMethods: [ "class_eval", "collection", "context", diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 0e9cdb3975..72e4621f40 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,13 +1,13 @@ # This configuration was generated by # `rubocop --auto-gen-config --auto-gen-only-exclude --exclude-limit 1400` -# on 2022-03-29 16:07:39 UTC using RuboCop version 1.22.2. +# on 2022-08-29 05:26:26 UTC using RuboCop version 1.35.1. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new # versions of RuboCop, may require this file to be generated again. -# Offense count: 1 -# Cop supports --auto-correct. +# Offense count: 2 +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: TreatCommentsAsGroupSeparators, ConsiderPunctuation, Include. # Include: **/*.gemfile, **/Gemfile, **/gems.rb Bundler/OrderedGems: @@ -25,20 +25,13 @@ Gemspec/RequiredRubyVersion: - 'engines/web/web.gemspec' # Offense count: 1 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). Layout/ClosingParenthesisIndentation: Exclude: - 'lib/reporting/queries/joins.rb' # Offense count: 2 -# Cop supports --auto-correct. -# Configuration parameters: EmptyLineBetweenMethodDefs, EmptyLineBetweenClassDefs, EmptyLineBetweenModuleDefs, AllowAdjacentOneLineDefs, NumberOfEmptyLines. -Layout/EmptyLineBetweenDefs: - Exclude: - - 'spec/lib/reports/report_loader_spec.rb' - -# Offense count: 2 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle. # SupportedStyles: empty_lines, no_empty_lines Layout/EmptyLinesAroundBlockBody: @@ -47,15 +40,15 @@ Layout/EmptyLinesAroundBlockBody: - 'spec/system/admin/order_cycles/list_spec.rb' # Offense count: 1 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: AllowDoxygenCommentStyle, AllowGemfileRubyComment. Layout/LeadingCommentSpace: Exclude: - 'spec/system/admin/enterprises_spec.rb' -# Offense count: 856 -# Cop supports --auto-correct. -# Configuration parameters: Max, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns. +# Offense count: 862 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: Max, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, AllowedPatterns, IgnoredPatterns. # URISchemes: http, https Layout/LineLength: Exclude: @@ -68,7 +61,6 @@ Layout/LineLength: - 'app/controllers/admin/subscriptions_controller.rb' - 'app/controllers/api/v0/order_cycles_controller.rb' - 'app/controllers/payment_gateways/paypal_controller.rb' - - 'app/controllers/spree/admin/reports_controller.rb' - 'app/controllers/spree/users_controller.rb' - 'app/controllers/user_confirmations_controller.rb' - 'app/helpers/angular_form_builder.rb' @@ -85,7 +77,6 @@ Layout/LineLength: - 'app/models/concerns/variant_stock.rb' - 'app/models/customer.rb' - 'app/models/enterprise.rb' - - 'app/models/enterprise_group.rb' - 'app/models/product_import/entry_processor.rb' - 'app/models/product_import/spreadsheet_entry.rb' - 'app/models/product_import/unit_converter.rb' @@ -111,23 +102,15 @@ Layout/LineLength: - 'engines/order_management/app/services/order_management/subscriptions/validator.rb' - 'engines/order_management/spec/services/order_management/order/updater_spec.rb' - 'engines/web/app/helpers/web/cookies_policy_helper.rb' - - 'engines/web/spec/features/consumer/cookies_spec.rb' - 'lib/discourse/single_sign_on.rb' - 'lib/open_food_network/enterprise_fee_applicator.rb' - 'lib/open_food_network/enterprise_fee_calculator.rb' - 'lib/open_food_network/enterprise_issue_validator.rb' - 'lib/open_food_network/order_cycle_form_applicator.rb' + - 'lib/open_food_network/order_cycle_permissions.rb' - 'lib/open_food_network/scope_variants_for_search.rb' - 'lib/reporting/line_items.rb' - - 'lib/reporting/reports/bulk_coop/bulk_coop_report.rb' - 'lib/reporting/reports/enterprise_fee_summary/report_data/enterprise_fee_type_total.rb' - - 'lib/reporting/reports/order_cycle_management/order_cycle_management_report.rb' - - 'lib/open_food_network/order_cycle_permissions.rb' - - 'lib/reporting/reports/orders_and_fulfillment/customer_totals_report.rb' - - 'lib/reporting/reports/orders_and_fulfillment/distributor_totals_by_supplier_report.rb' - - 'lib/reporting/reports/payments/payments_report.rb' - - 'lib/reporting/reports/products_and_inventory/lettuce_share_report.rb' - - 'lib/reporting/reports/sales_tax/sales_tax_report.rb' - 'lib/reporting/reports/xero_invoices/base.rb' - 'lib/spree/localized_number.rb' - 'lib/tasks/data.rake' @@ -145,12 +128,10 @@ Layout/LineLength: - 'spec/controllers/admin/subscriptions_controller_spec.rb' - 'spec/controllers/admin/variant_overrides_controller_spec.rb' - 'spec/controllers/api/v0/base_controller_spec.rb' - - 'spec/controllers/api/v0/enterprises_controller_spec.rb' - 'spec/controllers/api/v0/exchange_products_controller_spec.rb' - 'spec/controllers/api/v0/logos_controller_spec.rb' - 'spec/controllers/api/v0/order_cycles_controller_spec.rb' - 'spec/controllers/api/v0/orders_controller_spec.rb' - - 'spec/controllers/api/v0/product_images_controller_spec.rb' - 'spec/controllers/api/v0/products_controller_spec.rb' - 'spec/controllers/api/v0/promo_images_controller_spec.rb' - 'spec/controllers/api/v0/terms_and_conditions_controller_spec.rb' @@ -164,7 +145,6 @@ Layout/LineLength: - 'spec/controllers/spree/admin/orders/invoices_spec.rb' - 'spec/controllers/spree/admin/orders_controller_spec.rb' - 'spec/controllers/spree/admin/payment_methods_controller_spec.rb' - - 'spec/controllers/spree/admin/reports_controller_spec.rb' - 'spec/controllers/spree/admin/variants_controller_spec.rb' - 'spec/controllers/spree/credit_cards_controller_spec.rb' - 'spec/controllers/spree/orders_controller_spec.rb' @@ -187,13 +167,9 @@ Layout/LineLength: - 'spec/lib/open_food_network/tag_rule_applicator_spec.rb' - 'spec/lib/reports/customers_report_spec.rb' - 'spec/lib/reports/order_cycle_management_report_spec.rb' - - 'spec/lib/reports/order_grouper_spec.rb' - - 'spec/lib/reports/orders_and_fulfillment/orders_and_fulfillment_report_spec.rb' - 'spec/lib/reports/packing/packing_report_spec.rb' - 'spec/lib/reports/products_and_inventory_report_spec.rb' - 'spec/lib/reports/users_and_enterprises_report_spec.rb' - - 'spec/lib/reports/xero_invoices_report_spec.rb' - - 'spec/lib/stripe/authorize_response_patcher_spec.rb' - 'spec/mailers/order_mailer_spec.rb' - 'spec/mailers/producer_mailer_spec.rb' - 'spec/mailers/subscription_mailer_spec.rb' @@ -201,7 +177,6 @@ Layout/LineLength: - 'spec/models/concerns/calculated_adjustments_spec.rb' - 'spec/models/concerns/order_shipment_spec.rb' - 'spec/models/concerns/product_stock_spec.rb' - - 'spec/models/enterprise_group_spec.rb' - 'spec/models/enterprise_relationship_spec.rb' - 'spec/models/enterprise_spec.rb' - 'spec/models/exchange_spec.rb' @@ -227,7 +202,6 @@ Layout/LineLength: - 'spec/models/tag_rule/filter_payment_methods_spec.rb' - 'spec/models/tag_rule/filter_products_spec.rb' - 'spec/models/tag_rule/filter_shipping_methods_spec.rb' - - 'spec/models/terms_of_service_file_spec.rb' - 'spec/models/variant_override_spec.rb' - 'spec/requests/api/orders_spec.rb' - 'spec/requests/checkout/failed_checkout_spec.rb' @@ -287,6 +261,7 @@ Layout/LineLength: - 'spec/system/admin/variant_overrides_spec.rb' - 'spec/system/consumer/authentication_spec.rb' - 'spec/system/consumer/caching/shops_caching_spec.rb' + - 'spec/system/consumer/cookies_spec.rb' - 'spec/system/consumer/shopping/cart_spec.rb' - 'spec/system/consumer/shopping/checkout_auth_spec.rb' - 'spec/system/consumer/shopping/checkout_spec.rb' @@ -300,35 +275,20 @@ Layout/LineLength: - 'spec/views/spree/admin/payment_methods/index.html.haml_spec.rb' # Offense count: 1 -# Cop supports --auto-correct. -Layout/MultilineBlockLayout: - Exclude: - - 'spec/lib/reports/report_renderer_spec.rb' - -# Offense count: 1 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle. # SupportedStyles: symmetrical, new_line, same_line Layout/MultilineMethodCallBraceLayout: Exclude: - 'lib/reporting/queries/joins.rb' -# Offense count: 2 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, IndentationWidth. -# SupportedStyles: aligned, indented, indented_relative_to_receiver -Layout/MultilineMethodCallIndentation: - Exclude: - - 'lib/reporting/reports/customers/customers_report.rb' - -# Offense count: 20 -# Cop supports --auto-correct. +# Offense count: 22 +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: AllowInHeredoc. Layout/TrailingWhitespace: Exclude: - 'app/controllers/spree/admin/shipping_methods_controller.rb' - 'spec/controllers/spree/admin/shipping_methods_controller_spec.rb' - - 'spec/system/admin/enterprises_spec.rb' - 'spec/system/admin/order_spec.rb' - 'spec/system/admin/shipping_methods_spec.rb' - 'spec/system/flatpickr_spec.rb' @@ -357,6 +317,7 @@ Lint/DuplicateMethods: - 'lib/discourse/single_sign_on.rb' # Offense count: 1 +# This cop supports unsafe autocorrection (--autocorrect-all). Lint/DuplicateRequire: Exclude: - 'spec/lib/open_food_network/scope_variants_to_search_spec.rb' @@ -378,9 +339,8 @@ Lint/IneffectiveAccessModifier: Exclude: - 'app/models/spree/user.rb' - # Offense count: 1 -# Cop supports --auto-correct. +# This cop supports unsafe autocorrection (--autocorrect-all). # Configuration parameters: AllowedMethods. # AllowedMethods: instance_of?, kind_of?, is_a?, eql?, respond_to?, equal? Lint/RedundantSafeNavigation: @@ -388,6 +348,7 @@ Lint/RedundantSafeNavigation: - 'app/models/spree/payment.rb' # Offense count: 2 +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: AllowedMethods. # AllowedMethods: present?, blank?, presence, try, try!, in? Lint/SafeNavigationChain: @@ -396,22 +357,21 @@ Lint/SafeNavigationChain: - 'app/models/spree/stock/availability_validator.rb' # Offense count: 2 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: AllowUnusedKeywordArguments, IgnoreEmptyMethods, IgnoreNotImplementedMethods. Lint/UnusedMethodArgument: Exclude: - 'lib/reporting/queries/query_interface.rb' # Offense count: 5 -# Cop supports --auto-correct. -# Configuration parameters: AllowComments. +# This cop supports unsafe autocorrection (--autocorrect-all). Lint/UselessMethodDefinition: Exclude: - 'app/controllers/spree/user_registrations_controller.rb' - 'app/models/spree/gateway.rb' -# Offense count: 38 -# Configuration parameters: IgnoredMethods, CountRepeatedAttributes, Max. +# Offense count: 28 +# Configuration parameters: AllowedMethods, AllowedPatterns, IgnoredMethods, CountRepeatedAttributes, Max. Metrics/AbcSize: Exclude: - 'app/controllers/admin/enterprises_controller.rb' @@ -433,20 +393,14 @@ Metrics/AbcSize: - 'app/models/spree/return_authorization.rb' - 'lib/discourse/single_sign_on.rb' - 'lib/open_food_network/order_cycle_form_applicator.rb' - - 'lib/reporting/reports/bulk_coop/bulk_coop_report.rb' - - 'lib/reporting/reports/customers/customers_report.rb' - 'lib/open_food_network/order_cycle_permissions.rb' - - 'lib/reporting/reports/orders_and_distributors/orders_and_distributors_report.rb' - - 'lib/reporting/reports/packing/customer.rb' - - 'lib/reporting/reports/payments/payments_report.rb' - - 'lib/reporting/reports/sales_tax/sales_tax_report.rb' - 'lib/spree/core/controller_helpers/order.rb' - 'lib/tasks/enterprises.rake' - 'spec/services/order_checkout_restart_spec.rb' -# Offense count: 43 -# Configuration parameters: CountComments, Max, CountAsOne, ExcludedMethods, IgnoredMethods. -# IgnoredMethods: refine +# Offense count: 42 +# Configuration parameters: CountComments, Max, CountAsOne, ExcludedMethods, AllowedMethods, AllowedPatterns, IgnoredMethods. +# AllowedMethods: refine Metrics/BlockLength: Exclude: - 'app/models/spree/order/checkout.rb' @@ -474,7 +428,6 @@ Metrics/BlockLength: - 'spec/support/matchers/select2_matchers.rb' - 'spec/support/matchers/table_matchers.rb' - 'spec/swagger_helper.rb' - - 'spec/system/admin/order_cycles/complex_updating_specific_time_spec.rb' - 'spec/system/consumer/shopping/checkout_spec.rb' # Offense count: 1 @@ -483,7 +436,7 @@ Metrics/BlockNesting: Exclude: - 'app/models/spree/payment/processing.rb' -# Offense count: 50 +# Offense count: 45 # Configuration parameters: CountComments, Max, CountAsOne. Metrics/ClassLength: Exclude: @@ -502,7 +455,6 @@ Metrics/ClassLength: - 'app/controllers/spree/admin/payment_methods_controller.rb' - 'app/controllers/spree/admin/payments_controller.rb' - 'app/controllers/spree/admin/products_controller.rb' - - 'app/controllers/spree/admin/reports_controller.rb' - 'app/controllers/spree/admin/users_controller.rb' - 'app/controllers/spree/orders_controller.rb' - 'app/models/enterprise.rb' @@ -529,16 +481,13 @@ Metrics/ClassLength: - 'engines/order_management/app/services/order_management/order/updater.rb' - 'lib/open_food_network/enterprise_fee_calculator.rb' - 'lib/open_food_network/order_cycle_form_applicator.rb' - - 'lib/open_food_network/permissions.rb' - - 'lib/reporting/reports/bulk_coop/bulk_coop_report.rb' - - 'lib/reporting/reports/enterprise_fee_summary/scope.rb' - - 'lib/reporting/reports/order_cycle_management/order_cycle_management_report.rb' - 'lib/open_food_network/order_cycle_permissions.rb' - - 'lib/reporting/reports/payments/payments_report.rb' + - 'lib/open_food_network/permissions.rb' + - 'lib/reporting/reports/enterprise_fee_summary/scope.rb' - 'lib/reporting/reports/xero_invoices/base.rb' -# Offense count: 39 -# Configuration parameters: IgnoredMethods, Max. +# Offense count: 35 +# Configuration parameters: AllowedMethods, AllowedPatterns, IgnoredMethods, Max. Metrics/CyclomaticComplexity: Exclude: - 'app/controllers/admin/enterprises_controller.rb' @@ -565,18 +514,14 @@ Metrics/CyclomaticComplexity: - 'app/models/spree/zone.rb' - 'lib/discourse/single_sign_on.rb' - 'lib/open_food_network/enterprise_issue_validator.rb' - - 'lib/reporting/reports/bulk_coop/bulk_coop_report.rb' - - 'lib/reporting/reports/customers/customers_report.rb' - - 'lib/reporting/reports/orders_and_fulfillment/customer_totals_report.rb' - - 'lib/reporting/reports/payments/payments_report.rb' - 'lib/reporting/reports/xero_invoices/base.rb' - 'lib/spree/core/controller_helpers/order.rb' - 'lib/spree/core/controller_helpers/respond_with.rb' - 'lib/spree/localized_number.rb' - 'spec/models/product_importer_spec.rb' -# Offense count: 32 -# Configuration parameters: CountComments, Max, CountAsOne, ExcludedMethods, IgnoredMethods. +# Offense count: 26 +# Configuration parameters: CountComments, Max, CountAsOne, ExcludedMethods, AllowedMethods, AllowedPatterns, IgnoredMethods. Metrics/MethodLength: Exclude: - 'app/controllers/admin/enterprises_controller.rb' @@ -593,15 +538,12 @@ Metrics/MethodLength: - 'app/models/spree/preferences/preferable_class_methods.rb' - 'lib/discourse/single_sign_on.rb' - 'lib/open_food_network/order_cycle_form_applicator.rb' - - 'lib/reporting/reports/bulk_coop/bulk_coop_report.rb' - - 'lib/reporting/reports/enterprise_fee_summary/scope.rb' - - 'lib/reporting/reports/order_cycle_management/order_cycle_management_report.rb' - 'lib/open_food_network/order_cycle_permissions.rb' - - 'lib/reporting/reports/payments/payments_report.rb' + - 'lib/reporting/reports/enterprise_fee_summary/scope.rb' - 'lib/reporting/reports/xero_invoices/base.rb' - 'lib/tasks/sample_data/product_factory.rb' -# Offense count: 54 +# Offense count: 51 # Configuration parameters: CountComments, Max, CountAsOne. Metrics/ModuleLength: Exclude: @@ -641,9 +583,6 @@ Metrics/ModuleLength: - 'spec/lib/reports/customers_report_spec.rb' - 'spec/lib/reports/enterprise_fee_summary/authorizer_spec.rb' - 'spec/lib/reports/order_cycle_management_report_spec.rb' - - 'spec/lib/reports/order_grouper_spec.rb' - - 'spec/lib/reports/orders_and_fulfillment/customer_totals_report_spec.rb' - - 'spec/lib/reports/orders_and_fulfillment/orders_and_fulfillment_report_spec.rb' - 'spec/lib/reports/products_and_inventory_report_spec.rb' - 'spec/lib/reports/users_and_enterprises_report_spec.rb' - 'spec/models/spree/adjustment_spec.rb' @@ -670,8 +609,8 @@ Metrics/ParameterLists: - 'spec/support/controller_requests_helper.rb' - 'spec/system/admin/reports_spec.rb' -# Offense count: 7 -# Configuration parameters: IgnoredMethods, Max. +# Offense count: 5 +# Configuration parameters: AllowedMethods, AllowedPatterns, IgnoredMethods, Max. Metrics/PerceivedComplexity: Exclude: - 'app/controllers/spree/admin/taxons_controller.rb' @@ -679,10 +618,8 @@ Metrics/PerceivedComplexity: - 'app/models/enterprise_relationship.rb' - 'app/models/spree/ability.rb' - 'app/models/spree/order/checkout.rb' - - 'lib/reporting/reports/bulk_coop/bulk_coop_report.rb' - - 'lib/reporting/reports/payments/payments_report.rb' -# Offense count: 9 +# Offense count: 8 Naming/AccessorMethodName: Exclude: - 'app/controllers/spree/admin/taxonomies_controller.rb' @@ -716,8 +653,8 @@ Naming/MethodParameterName: Exclude: - 'app/services/process_payment_intent.rb' -# Offense count: 30 -# Configuration parameters: EnforcedStyle, CheckMethodNames, CheckSymbols, AllowedIdentifiers. +# Offense count: 28 +# Configuration parameters: EnforcedStyle, CheckMethodNames, CheckSymbols, AllowedIdentifiers, AllowedPatterns. # SupportedStyles: snake_case, normalcase, non_integer # AllowedIdentifiers: capture3, iso8601, rfc1123_date, rfc822, rfc2822, rfc3339 Naming/VariableNumber: @@ -725,7 +662,6 @@ Naming/VariableNumber: - 'app/controllers/spree/orders_controller.rb' - 'app/models/content_configuration.rb' - 'app/models/preference_sections/main_links_section.rb' - - 'lib/reporting/reports/orders_and_fulfillment/customer_totals_report.rb' - 'lib/spree/core/controller_helpers/common.rb' - 'spec/controllers/spree/admin/search_controller_spec.rb' - 'spec/factories/stock_location_factory.rb' @@ -741,13 +677,13 @@ Rails/ActiveRecordOverride: - 'app/models/spree/product.rb' # Offense count: 1 -# Cop supports --auto-correct. +# This cop supports unsafe autocorrection (--autocorrect-all). Rails/ApplicationController: Exclude: - 'engines/dfc_provider/app/controllers/dfc_provider/api/base_controller.rb' # Offense count: 6 -# Cop supports --auto-correct. +# This cop supports unsafe autocorrection (--autocorrect-all). Rails/ApplicationJob: Exclude: - 'app/jobs/bulk_invoice_job.rb' @@ -758,19 +694,19 @@ Rails/ApplicationJob: - 'app/jobs/subscription_placement_job.rb' # Offense count: 1 -# Cop supports --auto-correct. +# This cop supports unsafe autocorrection (--autocorrect-all). Rails/ApplicationMailer: Exclude: - 'app/mailers/spree/base_mailer.rb' # Offense count: 1 -# Cop supports --auto-correct. +# This cop supports unsafe autocorrection (--autocorrect-all). Rails/ApplicationRecord: Exclude: - 'lib/tasks/data/remove_transient_data.rb' # Offense count: 5 -# Cop supports --auto-correct. +# This cop supports unsafe autocorrection (--autocorrect-all). # Configuration parameters: NilOrEmpty, NotPresent, UnlessPresent. Rails/Blank: Exclude: @@ -812,7 +748,7 @@ Rails/HasAndBelongsToMany: - 'app/models/spree/variant.rb' - 'app/models/spree/zone.rb' -# Offense count: 47 +# Offense count: 45 # Configuration parameters: Include. # Include: app/models/**/*.rb Rails/HasManyOrHasOneDependent: @@ -838,9 +774,8 @@ Rails/HasManyOrHasOneDependent: - 'app/models/spree/taxonomy.rb' - 'app/models/spree/user.rb' - 'app/models/spree/variant.rb' - - 'app/models/subscription.rb' -# Offense count: 59 +# Offense count: 62 # Configuration parameters: Include. # Include: app/helpers/**/*.rb Rails/HelperInstanceVariable: @@ -881,7 +816,7 @@ Rails/InverseOf: # Offense count: 38 # Configuration parameters: Include. -# Include: app/controllers/**/*.rb +# Include: app/controllers/**/*.rb, app/mailers/**/*.rb Rails/LexicallyScopedActionFilter: Exclude: - 'app/controllers/admin/enterprise_groups_controller.rb' @@ -904,10 +839,9 @@ Rails/LexicallyScopedActionFilter: - 'app/controllers/spree/admin/zones_controller.rb' - 'app/controllers/spree/users_controller.rb' -# Offense count: 19 +# Offense count: 18 Rails/OutputSafety: Exclude: - - 'app/controllers/spree/admin/reports_controller.rb' - 'app/helpers/angular_form_helper.rb' - 'app/helpers/application_helper.rb' - 'app/helpers/reports_helper.rb' @@ -922,7 +856,7 @@ Rails/OutputSafety: - 'spec/system/admin/order_print_ticket_spec.rb' # Offense count: 1 -# Cop supports --auto-correct. +# This cop supports unsafe autocorrection (--autocorrect-all). Rails/RelativeDateConstant: Exclude: - 'lib/tasks/data/remove_transient_data.rb' @@ -936,7 +870,7 @@ Rails/SkipsModelValidations: - 'spec/models/spree/line_item_spec.rb' # Offense count: 5 -# Cop supports --auto-correct. +# This cop supports unsafe autocorrection (--autocorrect-all). # Configuration parameters: EnforcedStyle. # SupportedStyles: strict, flexible Rails/TimeZone: @@ -971,20 +905,20 @@ Security/Open: - 'app/services/image_importer.rb' # Offense count: 1 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). Style/BlockComments: Exclude: - 'spec/system/admin/tag_rules_spec.rb' # Offense count: 1 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: AllowOnConstant. Style/CaseEquality: Exclude: - 'spec/models/spree/payment_spec.rb' # Offense count: 3 -# Cop supports --auto-correct. +# This cop supports unsafe autocorrection (--autocorrect-all). Style/CaseLikeIf: Exclude: - 'app/controllers/admin/order_cycles_controller.rb' @@ -992,7 +926,7 @@ Style/CaseLikeIf: - 'app/models/spree/payment/processing.rb' # Offense count: 25 -# Cop supports --auto-correct. +# This cop supports unsafe autocorrection (--autocorrect-all). # Configuration parameters: EnforcedStyle. # SupportedStyles: nested, compact Style/ClassAndModuleChildren: @@ -1027,13 +961,14 @@ Style/ClassVars: - 'lib/spree/core/delegate_belongs_to.rb' # Offense count: 2 -# Configuration parameters: MaxUnannotatedPlaceholdersAllowed, IgnoredMethods. +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: MaxUnannotatedPlaceholdersAllowed, AllowedMethods, AllowedPatterns, IgnoredMethods. # SupportedStyles: annotated, template, unannotated Style/FormatStringToken: EnforcedStyle: unannotated # Offense count: 1 -# Cop supports --auto-correct. +# This cop supports unsafe autocorrection (--autocorrect-all). # Configuration parameters: EnforcedStyle. # SupportedStyles: always, always_true, never Style/FrozenStringLiteralComment: @@ -1041,7 +976,7 @@ Style/FrozenStringLiteralComment: - '.simplecov' # Offense count: 6 -# Cop supports --auto-correct. +# This cop supports unsafe autocorrection (--autocorrect-all). Style/GlobalStdStream: Exclude: - 'lib/tasks/data.rake' @@ -1050,8 +985,8 @@ Style/GlobalStdStream: - 'lib/tasks/subscriptions/debug.rake' - 'lib/tasks/subscriptions/test.rake' -# Offense count: 39 -# Configuration parameters: MinBodyLength. +# Offense count: 40 +# Configuration parameters: MinBodyLength, AllowConsecutiveConditionals. Style/GuardClause: Exclude: - 'app/controllers/admin/enterprises_controller.rb' @@ -1085,8 +1020,8 @@ Style/HashLikeCase: - 'app/models/enterprise.rb' # Offense count: 1 -# Cop supports --auto-correct. -# Configuration parameters: IgnoredMethods. +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: AllowedMethods, AllowedPatterns, IgnoredMethods. Style/MethodCallWithoutArgsParentheses: Exclude: - 'spec/system/flatpickr_spec.rb' @@ -1098,22 +1033,8 @@ Style/MissingRespondToMissing: - 'app/models/spree/gateway.rb' - 'app/models/spree/preferences/configuration.rb' -# Offense count: 1 -Style/MixinUsage: - Exclude: - - 'lib/reporting/reports/orders_and_fulfillment/orders_and_fulfillment_report.rb' - -# Offense count: 3 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle. -# SupportedStyles: literals, strict -Style/MutableConstant: - Exclude: - - 'lib/reporting/report_template.rb' - - 'lib/reporting/reports/packing/base.rb' - # Offense count: 22 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). Style/NestedModifier: Exclude: - 'spec/controllers/admin/subscriptions_controller_spec.rb' @@ -1127,7 +1048,7 @@ Style/NestedModifier: - 'spec/system/admin/payments_stripe_spec.rb' - 'spec/system/admin/reports_spec.rb' -# Offense count: 26 +# Offense count: 17 # Configuration parameters: AllowedMethods. # AllowedMethods: respond_to_missing? Style/OptionalBooleanParameter: @@ -1139,7 +1060,6 @@ Style/OptionalBooleanParameter: - 'app/models/enterprise_relationship.rb' - 'app/models/product_import/entry_processor.rb' - 'app/models/spree/order_contents.rb' - - 'app/models/spree/preferences/file_configuration.rb' - 'app/models/spree/shipment.rb' - 'engines/order_management/app/services/order_management/stock/estimator.rb' - 'lib/spree/core/controller_helpers/order.rb' @@ -1147,7 +1067,7 @@ Style/OptionalBooleanParameter: - 'spec/support/request/web_helper.rb' # Offense count: 1 -# Cop supports --auto-correct. +# This cop supports unsafe autocorrection (--autocorrect-all). # Configuration parameters: EnforcedStyle. # SupportedStyles: short, verbose Style/PreferredHashMethods: @@ -1155,13 +1075,13 @@ Style/PreferredHashMethods: - 'app/controllers/api/v0/shipments_controller.rb' # Offense count: 1 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: AllowMultipleReturnValues. Style/RedundantReturn: Exclude: - 'app/controllers/spree/admin/shipping_methods_controller.rb' -# Offense count: 205 +# Offense count: 209 Style/Send: Exclude: - 'app/controllers/split_checkout_controller.rb' @@ -1195,17 +1115,16 @@ Style/Send: - 'spec/services/cart_service_spec.rb' - 'spec/services/products_renderer_spec.rb' - 'spec/services/variant_units/option_value_namer_spec.rb' - - 'spec/spec_helper.rb' - 'spec/support/localized_number_helper.rb' # Offense count: 1 -# Cop supports --auto-correct. +# This cop supports unsafe autocorrection (--autocorrect-all). Style/SingleArgumentDig: Exclude: - 'app/services/checkout/form_data_adapter.rb' # Offense count: 4 -# Cop supports --auto-correct. +# This cop supports unsafe autocorrection (--autocorrect-all). Style/SlicingWithRange: Exclude: - 'app/helpers/spree/admin/navigation_helper.rb' @@ -1213,8 +1132,8 @@ Style/SlicingWithRange: - 'engines/order_management/app/services/order_management/subscriptions/validator.rb' - 'lib/discourse/single_sign_on.rb' -# Offense count: 28 -# Cop supports --auto-correct. +# Offense count: 29 +# This cop supports unsafe autocorrection (--autocorrect-all). # Configuration parameters: Mode. Style/StringConcatenation: Exclude: