From 167099badf07b9bfb049b08d6134dbb78c64415c Mon Sep 17 00:00:00 2001 From: Maikel Linke Date: Wed, 18 Feb 2026 09:44:19 +1100 Subject: [PATCH] Lint/NoReturnInBeginEndBlocks --- app/services/orders/handle_fees_service.rb | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/app/services/orders/handle_fees_service.rb b/app/services/orders/handle_fees_service.rb index 64e42f63ad..eb6211d5e8 100644 --- a/app/services/orders/handle_fees_service.rb +++ b/app/services/orders/handle_fees_service.rb @@ -130,12 +130,11 @@ module Orders def order_cycle_fees return @order_cycle_fees if defined? @order_cycle_fees + return [] unless order_cycle && distributor @order_cycle_fees = begin fees = [] - return fees unless order_cycle && distributor - order_cycle.exchanges.supplying_to(distributor).each do |exchange| exchange.enterprise_fees.per_item.each do |enterprise_fee| fee_value = FeeValue.new(fee: enterprise_fee, role: exchange.role)